Skip to content

Conversation

chengfang
Copy link
Contributor

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
Upgrade go-git library to 5.13.1 to fix CVEs CVE-2025-21614 and CVE-2025-21613

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:
This is a big bump from 5.1.0 to 5.13.1, so there are quite some version changes across various libs.

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jan 17, 2025
@openshift-ci openshift-ci bot requested review from chetan-rns and jopit January 17, 2025 19:19
Copy link

openshift-ci bot commented Jan 17, 2025

Hi @chengfang. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@keithchong keithchong self-requested a review January 17, 2025 20:40
Copy link
Collaborator

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira
Copy link

/lgtm

@ishitasequeira
Copy link

/ok-to-test

Copy link

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@svghadi
Copy link
Member

svghadi commented Jan 20, 2025

/retest

@svghadi
Copy link
Member

svghadi commented Jan 20, 2025

/lgtm
/approve

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, ishitasequeira, svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e3938a into redhat-developer:master Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants