Run Rollouts operator E2E tests in both namespace/cluster scoped #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwest
force-pushed
the
add-namespace-scoped-rollouts-test-nov-2024
branch
from
f8eb6f6 to
6d1b196
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/retest |
jgwest
force-pushed
the
add-namespace-scoped-rollouts-test-nov-2024
branch
from
6d1b196 to
1d14a0e
Compare
Signed-off-by: Jonathan West <[email protected]>
jgwest
force-pushed
the
add-namespace-scoped-rollouts-test-nov-2024
branch
from
1d14a0e to
9cd24db
Compare
Collaborator
|
/lgtm |
Member
Author
|
Thanks @jparsai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
At present, we only run the Argo Rollouts Operator cluster-scoped tests. This PR adds logic that allows us to ALSO run the namespace-scoped Argo Rollouts tests. (Ensuring coverage of both scenarios, for users of gitops operator)
How to test changes / Special notes to the reviewer:
I've tested it manually on clusterbot OpenShift, and all tests pass.