feat: Add support for pnpm package manager #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruromero
requested changes
May 21, 2025
Collaborator
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
I could only find the typo during the review. I don't think there's anything else that requires fixing.
Can you also review the CI checks and make sure they're passing?
Thanks
src/main/java/org/jboss/tools/intellij/componentanalysis/pnpm/PnNpmCAAnnotator.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
The CI is complaining about |
soul2zimate
force-pushed
the
issue176-main
branch
from
3beecbd to
7423bf0
Compare
soul2zimate
force-pushed
the
issue176-main
branch
from
7423bf0 to
e8a0dc2
Compare
|
soul2zimate
changed the title
Collaborator
Author
|
The CI is all good now. |
ruromero
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add support for pnpm package manager
Fixes: #176
This requires guacsec/trustify-da-java-client#133