feat: add support for yarn package manager #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@ruromero similar stuff for yarn, if you can give a quick review 😄 Thanks. |
ruromero
approved these changes
May 21, 2025
Collaborator
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
The PR is correctly implemented. I added 2 small suggestions that don't affect the functionality.
One thing that would be beneficial is also the addition of some unit testing for the new logic added to the Annotaror.
Finally, I see that there is too much repeated code when handling PsiFiles. We can consider creating a follow up task to create a utilities class and do a small refactor.
src/main/java/org/jboss/tools/intellij/componentanalysis/yarn/YarnCAAnnotator.java
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/componentanalysis/yarn/YarnCAAnnotator.java
Outdated
Show resolved
Hide resolved
soul2zimate
force-pushed
the
issue175-main
branch
from
98989e2 to
8af69e1
Compare
refactor: use CAUtil for various CAAnnotator
soul2zimate
force-pushed
the
issue175-main
branch
from
8af69e1 to
28864df
Compare
|
Collaborator
Author
|
rebased as per last review comment. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add support for yarn package manager
Fixes: #175