Skip to content

Conversation

@soul2zimate
Copy link
Collaborator

@soul2zimate soul2zimate commented Jun 3, 2025

This upgrades Gradle wrapper to 8.5 and Gradle IntelliJ Plugin to 2.x.

Fixes: #184

Since I am very new to the project, I am not 100% confident about this change.

It'd be really helpful if previous committers can review and guide me if I am doing anything wrong here.

cc: @zvigrinberg @xieshenzh @ruromero @sbouchet thanks in advance.

@soul2zimate soul2zimate changed the title chore: Upgrade gradle wrapper to 8.5 chore: upgrades Gradle wrapper to 8.5 and Gradle IntelliJ Plugin to 2.x. Jun 3, 2025
@ruromero ruromero self-requested a review June 3, 2025 09:51
@ruromero ruromero added this to the 202506 milestone Jun 3, 2025
@ruromero
Copy link
Collaborator

ruromero commented Jun 3, 2025

@soul2zimate Create an issue with a description of the problem and why all this is needed so that we can better understand the purpose and the proposed fix.

Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first sight changes look consistent. LGTM

@soul2zimate
Copy link
Collaborator Author

related issue: #184

@sbouchet
Copy link
Contributor

sbouchet commented Jun 3, 2025

that's look good !
take care to the failing check ( validation over other IJ versions ).
this need to be modified to use new goal for verifiying over the recommended/supported IJ version for your extension.
in the gradle file, use :

intellijPlatform {
...
  pluginVerification {
        ides {
            recommended()
        }
    }
}

and in the command line / github action, run gradle verifyPlugin . no need to pass an ide version anymore to check binary compatibility results.

@soul2zimate soul2zimate force-pushed the upgrade-main branch 2 times, most recently from beb9ba4 to a11a553 Compare June 4, 2025 01:30
@soul2zimate
Copy link
Collaborator Author

Thanks for the review @sbouchet , Would you mind to check for the new update ?

@soul2zimate soul2zimate marked this pull request as ready for review June 4, 2025 02:43
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now !

@soul2zimate
Copy link
Collaborator Author

thanks for the review @sbouchet 👍

@soul2zimate soul2zimate force-pushed the upgrade-main branch 4 times, most recently from 1112f36 to 6e51f6a Compare June 24, 2025 06:36
@soul2zimate
Copy link
Collaborator Author

This is bizarre, my local :verifyPlugin run doesn't fail at all....

@sonarqubecloud
Copy link

@soul2zimate soul2zimate merged commit 0dfec2b into redhat-developer:main Jun 27, 2025
8 checks passed
@soul2zimate soul2zimate deleted the upgrade-main branch June 27, 2025 02:27
@soul2zimate
Copy link
Collaborator Author

Thank you @sbouchet @ruromero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build the project giving strong warnings about unsupported Gradle IntelliJ Plugin version

3 participants