Skip to content

Conversation

@soul2zimate
Copy link
Collaborator

steps.changes_check.outputs.has_changes needs to be evaluated first.

fix: step "Check for changes since last nightly" needs to run before "Determine version and channel"

chore: add some validations and logging information

@soul2zimate soul2zimate requested a review from ruromero September 4, 2025 06:15
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you mind adding that the action only runs on the redhat-developer/intellij-dependency-analytics repository? I forgot to add it.
Thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@soul2zimate
Copy link
Collaborator Author

Looks good. Do you mind adding that the action only runs on the redhat-developer/intellij-dependency-analytics repository? I forgot to add it. Thanks

sure, I have added that condition

@ruromero
Copy link
Collaborator

ruromero commented Sep 4, 2025

Thank you!

@soul2zimate soul2zimate merged commit aebbf39 into redhat-developer:main Sep 5, 2025
8 checks passed
@soul2zimate soul2zimate deleted the script_fix_main branch September 5, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants