Skip to content

Conversation

@soul2zimate
Copy link
Collaborator

@soul2zimate soul2zimate commented Nov 21, 2025

  • build: Upgrade trustify-da-api-spec 2.0.2 and trustify-da-java-client 0.0.11
  • feat: update to trustify-da

fixes: #224

Hi @ruromero I am making this as draft, I need to wait for the v5 endpoint deployed and ready before I can merge this, right ?

@soul2zimate soul2zimate requested a review from ruromero November 21, 2025 02:33
@soul2zimate soul2zimate changed the title Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.9 build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.9 Nov 21, 2025
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing to set the TRUSTIFY_DA_BACKEND_URL that now has to be set. It must point to rhda.rhcloud.com

@ruromero
Copy link
Collaborator

  • build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.9
  • feat: update to trustify-da

fixes: #224

Hi @ruromero I am making this as draft, I need to wait for the v5 endpoint deployed and ready before I can merge this, right ?

The v5 endpoint is available on stage already

@soul2zimate
Copy link
Collaborator Author

You're missing to set the TRUSTIFY_DA_BACKEND_URL that now has to be set. It must point to rhda.rhcloud.com

Thanks. I have updated the PR to set the required TRUSTIFY_DA_BACKEND_URL .

The v5 endpoint is available on stage already

OK, I can test against v5 stage URL. But if I merge this it will be published to nightly build before the prod backend service gets ready.

Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

@ruromero
Copy link
Collaborator

You're missing to set the TRUSTIFY_DA_BACKEND_URL that now has to be set. It must point to rhda.rhcloud.com

Thanks. I have updated the PR to set the required TRUSTIFY_DA_BACKEND_URL .

The v5 endpoint is available on stage already

OK, I can test against v5 stage URL. But if I merge this it will be published to nightly build before the prod backend service gets ready.

We should indeed wait until the backend is deployed in prod. Thanks for noticing

@ruromero ruromero marked this pull request as ready for review November 21, 2025 12:48
@soul2zimate soul2zimate changed the title build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.9 build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.10 Nov 27, 2025
@soul2zimate
Copy link
Collaborator Author

Hi @ruromero how about this one? Should I merge or wait until the deployments are ready?

@ruromero
Copy link
Collaborator

this will end up creating a nightly that won't work so it must wait

@soul2zimate
Copy link
Collaborator Author

soul2zimate commented Nov 29, 2025

since last update, I have upgraded trustify-da-api-spec 2.0.2 and trustify-da-java-client 0.0.11

I also tested against latest tpa and da stages and fixes two issues:

  • NPE when issue.getRemediation() return null (no remediation available from report)
  • eliminate duplicate vulnerability annotations in CAAnnotator

please review when you have time next week and remove the "hold", then I will merge this one. Thanks.

Create single annotation per element instead of one per vulnerability source to avoid showing duplicate messages for the same dependency
@soul2zimate soul2zimate changed the title build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.10 build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.11 Dec 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@soul2zimate
Copy link
Collaborator Author

@ruromero Thank you for the review

@soul2zimate soul2zimate merged commit d7ef052 into redhat-developer:main Dec 1, 2025
9 of 10 checks passed
@soul2zimate soul2zimate deleted the api_client_upgrade branch December 1, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.9

2 participants