-
Notifications
You must be signed in to change notification settings - Fork 22
build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.11 #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade trustify-da-api-spec 2.0.1 and trustify-da-java-client 0.0.11 #225
Conversation
ruromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing to set the TRUSTIFY_DA_BACKEND_URL that now has to be set. It must point to rhda.rhcloud.com
src/main/java/org/jboss/tools/intellij/componentanalysis/gradle/GradleCAAnnotator.java
Show resolved
Hide resolved
Thanks. I have updated the PR to set the required
OK, I can test against v5 stage URL. But if I merge this it will be published to nightly build before the prod backend service gets ready. |
ruromero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you
We should indeed wait until the backend is deployed in prod. Thanks for noticing |
e5c4d30 to
8d2f1f6
Compare
…ired TRUSTIFY_DA_BACKEND_URL before creating ExhortApi instance
8d2f1f6 to
2342a8d
Compare
|
Hi @ruromero how about this one? Should I merge or wait until the deployments are ready? |
|
this will end up creating a nightly that won't work so it must wait |
2342a8d to
a081ead
Compare
|
since last update, I have upgraded I also tested against latest tpa and da stages and fixes two issues:
please review when you have time next week and remove the "hold", then I will merge this one. Thanks. |
Create single annotation per element instead of one per vulnerability source to avoid showing duplicate messages for the same dependency
a081ead to
dd2c0e1
Compare
|
|
@ruromero Thank you for the review |



fixes: #224
Hi @ruromero I am making this as draft, I need to wait for the v5 endpoint deployed and ready before I can merge this, right ?