generated from redhat-developer/new-project-template
-
Notifications
You must be signed in to change notification settings - Fork 66
docs: update python docs to clarify setting a breakpoint #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scweber-cisco
wants to merge
2
commits into
redhat-developer:main
Choose a base branch
from
scweber-cisco:scweber/update-docs-dap-breakpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry to be not clear. When you are not using PyCharm like IJ community you have not this issue.
Please separate your content in 2 sections : with and without PyCharm.
I say if you are using PyCharm you need 2 steps otherwise you can just set the breakpoint in one step with community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow. I just tried using Intellij IDEA CE, created a python project, installed LSP4IJ, and configured a python-debugpy DAP. I still have take both steps to get a DAP Breakpoint. Can you show me how you are avoiding the second step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem comes from when a file can accept several breakpoint type.
If the file accept just one breakpoint type, you add te breakpoint just by clickong on the editor gutter. With IC you should not having python breakpoint type, just dap breakpoint type.
With PyCharm it provides python line breakpoint type so you need to do te 2 steps to create dap breakpoint type and not python line breakpoint type
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you seeing this behavior in Python files, or in other source code types? I am not able to see DAP Breakpoint as the one and only breakpoint type in Python files either in PyCharm, or in IDEA CE. This particular file that I'm modifying in this PR is specific to Python, correct? I'm happy to adjust the text here to be less specific, if that would be better? Something like "Setting a breakpoint may require two steps in some files due to multiple breakpoint types being defined" 🤷