RHIDP-5515: Default PVC and Secret configuration update #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1024/ @ 04/09/25 14:07:13 |
jmagak
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
gazarenkov
suggested changes
Mar 27, 2025
Member
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
Not sure I understand it in general.
If it is for RHIDP-5515 I think the point is to describe default configuration of Secrets and PVCs. The key moments are:
- It is a part of default operator configuration (see https://github.com/redhat-developer/rhdh-operator/blob/main/docs/configuration.md#default-configuration about what is it)
- Default configuration of PVCs and Secrets mounted as files (see pvcs.yaml and secret-files.yaml in this table https://github.com/redhat-developer/rhdh-operator/blob/main/docs/configuration.md#default-configuration-files) can use annotations to specify/refine some aspects of mounting such as:
- Mount path, see https://github.com/redhat-developer/rhdh-operator/blob/main/docs/configuration.md#rhdhredhatcommount-path-to-configure-mount-path
- Containers where the files will be mounted to, see https://github.com/redhat-developer/rhdh-operator/blob/main/docs/configuration.md#rhdhredhatcomcontainers-for-mounting-volume-to-specific-containers
Hope it helps a bit and please let me know if you need any additional help.
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
893501c to
c7e3470
Compare
linfraze
reviewed
Mar 31, 2025
Member
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
The content looks good, but the structure should comply with the following guidelines:
- How to write proc modules: https://redhat-documentation.github.io/modular-docs/#con-creating-procedure-modules_writing-mod-docs
- Template for proc modules: https://github.com/redhat-documentation/modular-docs/blob/main/modular-docs-manual/files/TEMPLATE_PROCEDURE_doing-one-procedure.adoc?plain=1
- How to format proc modules with optional/conditional steps: https://www.ibm.com/docs/en/ibm-style?topic=format-procedures#indicating-optional-and-conditional-steps
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-secret-mounting.adoc
Outdated
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
c7e3470 to
be4d1e2
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
be4d1e2 to
d5f3b97
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
d5f3b97 to
a049df8
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
a049df8 to
b58369b
Compare
gazarenkov
suggested changes
Apr 3, 2025
Member
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
Please make sure your content fits the title and descriptions fit examples (Secret vs PVC etc)
modules/configuring-external-databases/proc-configuring-pvc-mounts.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-mounts.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-mounts.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-mounts.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-external-databases/proc-configuring-pvc-mounts.adoc
Outdated
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
b58369b to
e965cdf
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
e965cdf to
7b3f396
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
7b3f396 to
4452232
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
4452232 to
8aa724a
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
3bf2c4d to
7923733
Compare
gazarenkov
suggested changes
Apr 8, 2025
...figuring-external-databases/proc-configuring-default-configuration-for-secrets-and-pvcs.adoc
Outdated
Show resolved
Hide resolved
...figuring-external-databases/proc-configuring-default-configuration-for-secrets-and-pvcs.adoc
Outdated
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
a3d7786 to
9ff126b
Compare
jmagak
changed the title
gazarenkov
reviewed
Apr 9, 2025
...figuring-external-databases/proc-configuring-default-configuration-for-secrets-and-pvcs.adoc
Outdated
Show resolved
Hide resolved
gazarenkov
approved these changes
Apr 9, 2025
Member
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
Note: even if the content looks in general correct, the context is not clear since we still do not have downstream documentation of Operator default configuration (part of which is this content). See: https://issues.redhat.com/browse/RHIDP-3800
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
689e550 to
c3afc82
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
c3afc82 to
689e550
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
689e550 to
0d1191e
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
313fc8d to
9c06090
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
9c06090 to
68472e2
Compare
jmagak
force-pushed
the
RHIDP-5515-document-default-PVC-and-Secret-configuration-update
branch
from
68472e2 to
f5ac51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): main, 1.5
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5515
Preview link: 9. Configuring default mounts for Secrets and PVCs