Skip to content

Conversation

@hmanwani-rh
Copy link
Member

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.6
Issue:
RHIDP-6570
Preview:

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Apr 16, 2025

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but we probably should include more information about what conditional rule to use and who to set it to. As well as what specific steps the team lead will need to take to ensure that they can see the roles and permissions that they create. Here is some docs that I have written for the RBAC backend plugin upstream.

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly minor, and I need to fix it in the upstream docs as well, but I am working on removing the resource type from the policy.entity.create permission. This means that at some point in the future, admins will no longer be able to create permissions using policy-entity, create and will instead need to use policy.entity.create, create.

I was hoping that we could use your PR to make that change. It looks like the create policy permission is only referenced in one other location. Do you mind updating it as well to remove the policy-entity from policy.entity.create?

@hmanwani-rh hmanwani-rh added the Technical review done ⛅ Any procedure has been succesfully tested label Apr 24, 2025
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@themr0c themr0c merged commit 34bf260 into redhat-developer:main Apr 29, 2025
3 checks passed
@themr0c
Copy link
Member

themr0c commented Apr 29, 2025

/cherry-pick release-1.6

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #1115

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants