RHIDP-6571 - remove configuring the base URL for Operator-based #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… base URL is no longer required Signed-off-by: Fabrice Flore-Thébault <[email protected]>
themr0c
added
Peer review needed 📖
Technical review needed 🔩
themr0c
commented
Apr 24, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Apr 24, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1096/ @ 04/30/25 12:44:48 |
themr0c
commented
Apr 24, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
rm3l
reviewed
Apr 24, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Apr 28, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Apr 28, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
pabel-rh
reviewed
Apr 28, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
linfraze
reviewed
Apr 28, 2025
Member
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
A few comments / suggestions
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
…n.adoc Co-authored-by: Priyanka Abel <[email protected]>
…n.adoc Co-authored-by: Lindsey Frazier <[email protected]>
themr0c
commented
Apr 30, 2025
themr0c
commented
Apr 30, 2025
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
pabel-rh
approved these changes
Apr 30, 2025
themr0c
added
Technical review done ⛅
Contributor
|
@themr0c: new pull request created: #1120 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Operator-based deployments configuring the base URL is no longer required
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
/cherry-pick release-1.6
Issue:
https://issues.redhat.com/browse/RHIDP-6571
https://issues.redhat.com/browse/RHIDP-6174
https://issues.redhat.com/browse/RHIDP-6670
Preview: