Skip to content

RHIDP-5421 - Document which plugins in RHDH have metrics #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmanwani-rh merged 12 commits into from
May 13, 2025
Merged

RHIDP-5421 - Document which plugins in RHDH have metrics #1110

hmanwani-rh merged 12 commits into from
May 13, 2025

Conversation

@Gerry-Forde
Copy link
Member

@Gerry-Forde Gerry-Forde commented Apr 28, 2025 •
edited
Loading

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
main, 1.6

Issue:
RHIDP-5421

Preview:
Installing and configuring Keycloak: Metrics

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Apr 28, 2025 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1110/ @ 05/13/25 13:28:28

linfraze
linfraze reviewed May 5, 2025
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and suggestions. If time becomes an issue, we might consider circling back to a couple things post-GA.

@Gerry-Forde Gerry-Forde marked this pull request as ready for review May 7, 2025 08:28
AndrienkoAleksandr
AndrienkoAleksandr approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I left just one comment.

@Gerry-Forde Gerry-Forde added Technical review done ⛅ Any procedure has been succesfully tested Ready to merge 💂 and removed Technical review needed 🔩 Test all the procedures labels May 13, 2025
@hmanwani-rh
Copy link
Member

hmanwani-rh commented May 13, 2025

/cherry-pick release-1.6

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented May 13, 2025

@hmanwani-rh: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hmanwani-rh hmanwani-rh merged commit 834b08a into redhat-developer:main May 13, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented May 13, 2025

@hmanwani-rh: new pull request created: #1160

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

2 more reviewers

@linfraze linfraze linfraze left review comments

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gerry-Forde @rhdh-bot @hmanwani-rh @openshift-cherrypick-robot @AndrienkoAleksandr @linfraze