-
Notifications
You must be signed in to change notification settings - Fork 57
RHIDP-7833 Follow more logical user flow for authenticating with Azure #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1227/ @ 07/04/25 12:12:09 |
a97d361 to
29a77fe
Compare
modules/authentication/proc-enabling-user-authentication-with-microsoft-azure.adoc
Outdated
Show resolved
Hide resolved
…microsoft-azure.adoc
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
kim-tsao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to specify two apps; one for auth and one for msgraph. The app for msgraph requires application level permissions only. See upstream docs. I will discuss this in the team call tomorrow and get back to you.
|
@kim-tsao What would be the reason for two separate apps? Security and separation of concerns? Drawback for the user will be more complexity (set up two apps rather than one), I'd like to avoid it if it is not necessary. |
modules/authentication/proc-enabling-user-authentication-with-microsoft-azure.adoc
Show resolved
Hide resolved
modules/authentication/proc-enabling-user-authentication-with-microsoft-azure.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-user-authentication-with-microsoft-azure.adoc
Show resolved
Hide resolved
@themr0c we looked into this further and found that one app is enough. When the user signs in through the authentication flow, they are provided an access token ONLY with delegated permissions, while the backend catalog plugin will have the granted application permissions. So we are good to use one app as long as the delegated/application permissions are set up correctly. |
…microsoft-azure.adoc
…microsoft-azure.adoc Co-authored-by: Jessica He <[email protected]>
|
@JessicaJHee @kim-tsao can you formally put your seal of approval? |
JessicaJHee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you @themr0c for all your work!
Gerry-Forde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Reorganize the content in a more logical way, for consistency with #1224 (consistent user flow, consistent formatting and sentences).
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.7
Issue:
https://issues.redhat.com/browse/RHIDP-7833
https://issues.redhat.com/browse/RHIDP-7636
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1227/authentication/#enabling-user-authentication-with-microsoft-azure