RHIDP-7834-RHIDP-7634-RHIDP-598 Refactor authenticating with RHBK #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themr0c
force-pushed
the
RHIDP-7834-RHIDP-7634-RHIDP-5981
branch
from
a13c77c to
e152696
Compare
themr0c
force-pushed
the
RHIDP-7834-RHIDP-7634-RHIDP-5981
branch
from
e152696 to
a7ec747
Compare
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1231/ @ 07/07/25 14:44:48 |
themr0c
force-pushed
the
RHIDP-7834-RHIDP-7634-RHIDP-5981
branch
from
a7ec747 to
62b23eb
Compare
themr0c
commented
Jun 17, 2025
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
themr0c
force-pushed
the
RHIDP-7834-RHIDP-7634-RHIDP-5981
branch
from
62b23eb to
c07d777
Compare
themr0c
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
themr0c
commented
Jun 27, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
JessicaJHee
reviewed
Jun 27, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Jun 30, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Jul 7, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Jul 7, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Jul 7, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
themr0c
commented
Jul 7, 2025
modules/authentication/proc-enabling-user-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Member
Author
|
@Gerry-Forde @JessicaJHee I adressd all your comments. Can you review again? |
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
JessicaJHee
approved these changes
Jul 7, 2025
Member
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
LGTM, thank you @themr0c!
themr0c
added
Technical review done ⛅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.7
Issue:
https://issues.redhat.com/browse/RHIDP-7834
https://issues.redhat.com/browse/RHIDP-7634
https://issues.redhat.com/browse/RHIDP-5981
Preview: