Skip to content

RHIDP-5152: Add Frontend Plugn Wiring Section #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jul 6, 2025

@jmagak jmagak force-pushed the RHIDP-5152-Add-Frontend-Plugin-Wiring-section-to-Installing-and-viewing-plugins branch from 2446db4 to 76d0e47 Compare July 7, 2025 09:30
@jmagak jmagak requested a review from gashcrumb July 7, 2025 09:32
@gashcrumb
Copy link
Member

There's also a couple more sections worth mentioning:

apologies if I missed those, I'm still looking through this.

@jmagak jmagak force-pushed the RHIDP-5152-Add-Frontend-Plugin-Wiring-section-to-Installing-and-viewing-plugins branch from 76d0e47 to bbf271f Compare July 9, 2025 08:12
@jmagak
Copy link
Member Author

jmagak commented Jul 9, 2025

@gashcrumb, Please have a look at this PR. I have made some changes to incorporate the following sections:

* Declare a new full page by defining a new route
* Extend to an existing page using router bindings
* Use mount points within the application
* Provide additional utility APIs or replace existing ones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure is it worth adding mention of the SignInPage, scaffolder or techdocs extensions etc in this list? This seems like a high-level overview of features, so maybe it doesn't need to be an exhaustive list I guess.

* `/context` type that serves to create React contexts
* `/cards` type for regular React components

The following is an example of the overall configuration structure of a mount point:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this section that focuses on mount points would be better in the "using mount points section", as they're used across the app, whereas entity tabs are limited to only catalog items. I was just reminded too that the conditional viewing of a component is done as part of the mount point configuration, which could almost warrant it's own section as there's a few conditional functions that are available and we probably could go into a little more detail on what's possible with the conditional functions for mount points.,

[source,yaml]
----
import { lightTheme } from './lightTheme';
import { darkTheme } from './darkTheme';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth linking to here for folks wondering how to create these?

@jmagak jmagak force-pushed the RHIDP-5152-Add-Frontend-Plugin-Wiring-section-to-Installing-and-viewing-plugins branch from 7d5bbe5 to 53aa209 Compare August 4, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants