Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Jul 8, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jul 8, 2025

@themr0c themr0c marked this pull request as ready for review October 13, 2025 17:40
Copy link
Member

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! One thing to add is that for OIDC auth with RHBK, the oidcLdapUuidMatchingAnnotation resolver is used by default for resolving users from LDAP. This resolver is more secure but requires setup on the Keycloak side. How this works is well documented in the following PR descriptions:

Please see the instructions to set up a custom scope in the Keycloak client here in the PR description under How to test changes / Special notes to the reviewer and an additional config here.

Copy link
Member

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ap.adoc

Co-authored-by: Jessica He <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c themr0c added Technical review needed 🔩 Test all the procedures and removed Technical review done ⛅ Any procedure has been succesfully tested labels Oct 17, 2025
@deerskindoll deerskindoll merged commit bdc4511 into redhat-developer:main Oct 20, 2025
3 checks passed
deerskindoll added a commit to deerskindoll/red-hat-developers-documentation-rhdh that referenced this pull request Oct 20, 2025
…per#1268)

* RHIDP-7612 Added _Enablig user provisioning with LDAP_

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

Co-authored-by: Jana Vrbkova <[email protected]>

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

Co-authored-by: Jessica He <[email protected]>

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

Co-authored-by: Jessica He <[email protected]>

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

Co-authored-by: Jessica He <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>

---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Jana Vrbkova <[email protected]>
Co-authored-by: Jessica He <[email protected]>
jmagak pushed a commit that referenced this pull request Oct 20, 2025
* RHIDP-7612 Added _Enablig user provisioning with LDAP_



* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc



* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc



* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc



* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc

* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc



* Update modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc




---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Jessica He <[email protected]>
@themr0c themr0c deleted the RHIDP-7612 branch November 6, 2025 11:27
@themr0c
Copy link
Member Author

themr0c commented Nov 6, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #1268 failed to apply on top of branch "release-1.8":

Applying: RHIDP-7612 Added _Enablig user provisioning with LDAP_
Using index info to reconstruct a base tree...
M	assemblies/assembly-authenticating-with-rhbk.adoc
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc
Auto-merging modules/authentication/proc-enabling-user-provisioning-with-ldap.adoc
Auto-merging assemblies/assembly-authenticating-with-rhbk.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-7612 Added _Enablig user provisioning with LDAP_

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants