feat: migrate lifecycle/support metadata to overlay repo for all supported plugins in downstream-plugins file RHIDP-7526 #1297
+445
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes in plugin versions and configurations. Added new plugins, removed deprecated ones, and adjusted the structure for better clarity. Enhanced the script for generating supported plugins to accommodate YAML files and improved output formatting. Co-author: cursor
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1297/ @ 08/12/25 06:49:17 |
polasudo
changed the title
nickboldt
reviewed
Aug 8, 2025
| * `@red-hat-developer-hub/backstage-plugin-marketplace` | ||
| * `@red-hat-developer-hub/backstage-plugin-quickstart` |
There was a problem hiding this comment.
this appears to be an on-by-default plugin. https://github.com/redhat-developer/rhdh/blob/main/dynamic-plugins.default.yaml#L628-L629
were you looking at an older branch?
There was a problem hiding this comment.
looks like it, i will double check it
nickboldt
reviewed
Aug 8, 2025
| @@ -67,7 +67,10 @@ titlecase() { | |||
| case $f in | |||
| aap) echo -n "Ansible Automation Platform (AAP) ";; | |||
| # UPPERCASE these exceptions | |||
| acr|cd|ocm|rbac) echo -n "${f^^} ";; | |||
| acr) echo -n "ACR ";; | |||
nickboldt
reviewed
Aug 8, 2025
| @@ -79,7 +82,11 @@ titlecase() { | |||
| sonarqube) echo -n "SonarQube ";; | |||
| techdocs) echo -n "TechDocs ";; | |||
| # Uppercase the first letter | |||
| *) echo -n "${f^} " ;; | |||
| *) | |||
There was a problem hiding this comment.
why 5 lines when a single line achieved the same thing?
nickboldt
reviewed
Aug 8, 2025
nickboldt
reviewed
Aug 8, 2025
| Name=$(yq -r '.metadata.name' "$y") | ||
| Plugin_Title=$(yq -r '.metadata.title' "$y") | ||
|
|
||
| # Use the actual packageName from spec, fallback to name |
There was a problem hiding this comment.
Suggested change
| # Use the actual packageName from spec, fallback to name | |
| # Use .spec.packageName, or if not set use .metadata.name |
nickboldt
reviewed
Aug 8, 2025
| if [[ $QUIET -eq 0 ]]; then echo " * [$c] $key [ community-plugins ] = ${csv[$key]}"; fi | ||
| echo -e "${adoc3[$key]}" >> "${0/.sh/.ref-community-plugins}"; | ||
| echo -e "${csv[$key]}" >> "${0/.sh/.csv}" | ||
| # Process temporary files instead of associative arrays |
There was a problem hiding this comment.
Suggested change
| # Process temporary files instead of associative arrays | |
| # Process temporary files |
nickboldt
reviewed
Aug 8, 2025
| echo -e "${adoc3[$key]}" >> "${0/.sh/.ref-community-plugins}"; | ||
| echo -e "${csv[$key]}" >> "${0/.sh/.csv}" | ||
| # Process temporary files instead of associative arrays | ||
| for i in 1 2 3; do |
There was a problem hiding this comment.
if we're switching to files why not use target file names instead of adoc1.tmp and this 1 2 3 loop?
nickboldt
reviewed
Aug 8, 2025
| @@ -277,17 +308,22 @@ for j in $jsons; do | |||
|
|
|||
| # TODO include missing data fields for Provider and Description - see https://issues.redhat.com/browse/RHIDP-3496 and https://issues.redhat.com/browse/RHIDP-3440 | |||
|
|
|||
| # Use temporary files instead of associative arrays | |||
There was a problem hiding this comment.
Suggested change
| # Use temporary files instead of associative arrays | |
| # Use temporary files to allow sorting later |
this might be an error; only BACKEND plugins have the -dynamic folder suffix; front end ones do not. For example
|
But it exists here:
So I think the issue is there's no catalog entity for it? If so we need to add one. |
…namic plugins and updated temporary file handling based on comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation for supported and preinstalled dynamic plugins, making the lists more accurate and consistent. The main changes involve reordering, adding, and removing plugins from the lists, as well as updating plugin details and environment variables.
Assisted-by: Cursor
changes:
Header (schema) difference
Old (main):
"Name","Plugin","Role","Version","Support Level","Path","Required Variables","Default"New (current):
"Name","Plugin","Role","Version","Support Level","Lifecycle","Path","Required Variables","Default"Lifecycle(typicallyactive, fromspec.lifecycle)High-level changes
Data source switched: JSON wrappers ➜ YAML marketplace packages
One new column added:
LifecycleFiltering:
-dynamic)oci://entries - not sure if they should be there but during working on this task they were found there but i was not sure if they should be there also@redhatpackages at package scope - same as aboveRequired variables extracted from YAML
spec.appConfigExamples[].contentDefault state derived from
dynamic-plugins.default.yamlPlugin set differences
@red-hat-developer-hub/backstage-plugin-quickstartWhy removed: dynamic-only filtering
quickstartdoes not have a dynamic wrapper, so it is excluded.@nickboldt what u suggest should i return it or not ?
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
Issue:
Preview: