Skip to content

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Sep 22, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Sep 22, 2025

Copy link

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better to me. @benwilcock wdyt?

Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, @pabel-rh.

@benwilcock
Copy link

Looks better, thanks folks. /lgtm

@jmagak
Copy link
Member

jmagak commented Sep 24, 2025

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit 47034aa into redhat-developer:main Sep 24, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: #1403 failed to apply on top of branch "release-1.7":

Applying: First draft
Applying: Included content for adding a new llm provider
Using index info to reconstruct a base tree...
M	artifacts/attributes.adoc
M	assemblies/assembly-customizing-developer-lightspeed.adoc
M	modules/developer-lightspeed/proc-installing-and-configuring-lightspeed.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/developer-lightspeed/proc-installing-and-configuring-lightspeed.adoc
Auto-merging assemblies/assembly-customizing-developer-lightspeed.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-customizing-developer-lightspeed.adoc
Auto-merging artifacts/attributes.adoc
CONFLICT (content): Merge conflict in artifacts/attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Included content for adding a new llm provider

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

themr0c pushed a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Oct 13, 2025
…t-developer#1403)

* First draft

* Included content for adding a new llm provider

* Added k8s secret

* Incorporated Jordan's comment

* Incorporated Judy's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants