Skip to content

RHIDP-8818: updated yaml file #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2025
Merged

RHIDP-8818: updated yaml file #1466

merged 7 commits into from
Oct 30, 2025
+35 −23

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Oct 29, 2025 •
edited
Loading

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 29, 2025 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1466/ @ 10/30/25 16:17:28

debsmita1
debsmita1 reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, rest looks good to me

@pabel-rh pabel-rh requested a review from debsmita1 October 30, 2025 07:36
debsmita1
debsmita1 reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@pabel-rh pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Oct 30, 2025
jmagak
jmagak reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, otherwise, lgtm.

@jmagak
Copy link
Member

jmagak commented Oct 30, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit 6a56064 into redhat-developer:main Oct 30, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@jmagak: new pull request created: #1469

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@debsmita1 debsmita1 debsmita1 left review comments

@jmagak jmagak jmagak approved these changes

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pabel-rh @rhdh-bot @jmagak @openshift-cherrypick-robot @debsmita1