Skip to content

RHIDP-8627: Templates lifecycle management #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagak merged 9 commits into from
Nov 3, 2025
Merged

RHIDP-8627: Templates lifecycle management #1470

jmagak merged 9 commits into from
Nov 3, 2025

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Oct 31, 2025 •
edited
Loading

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 31, 2025 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1470/ @ 11/03/25 18:34:20

@pabel-rh pabel-rh requested a review from Zaperex November 3, 2025 04:46
Zaperex
Zaperex suggested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the example config

@pabel-rh pabel-rh requested a review from Zaperex November 3, 2025 14:17
Zaperex
Zaperex reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right we should also update the sentences around this code block example since they still reference it as if it was a global rule.

@pabel-rh pabel-rh requested a review from Zaperex November 3, 2025 14:52
@pabel-rh pabel-rh requested a review from Zaperex November 3, 2025 14:58
Zaperex
Zaperex suggested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I guess just one more addition is to add the scaffolded-from action into our example as well

@pabel-rh pabel-rh requested a review from Zaperex November 3, 2025 15:10
Zaperex
Zaperex approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@Zaperex Zaperex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 3, 2025
@pabel-rh pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Nov 3, 2025
jmagak
jmagak reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, @pabel-rh.

@openshift-ci openshift-ci bot removed the lgtm label Nov 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

New changes are detected. LGTM label has been removed.

@jmagak
Copy link
Member

jmagak commented Nov 3, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 3, 2025

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit 9f7dd3e into redhat-developer:main Nov 3, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 3, 2025

@jmagak: new pull request created: #1479

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

+1 more reviewer

@Zaperex Zaperex Zaperex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Zaperex Zaperex

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pabel-rh @rhdh-bot @jmagak @openshift-cherrypick-robot @Zaperex