generated from redhat-developer/new-project-template
-
Notifications
You must be signed in to change notification settings - Fork 59
RHDHBUGS-2128 part 2, Add missing $ prompt in code blocks for command examples #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhite8041
wants to merge
6
commits into
redhat-developer:main
Choose a base branch
from
lhite8041:RHDHBUGS-2128b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−93
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
08d0687
Added prompt to commands in 3 files, areas authentication and authori…
lhite8041 3394462
Added prompt to commands in 8 files, area observe
lhite8041 eefb037
Added prompt to commands in 3 files, area openshift-ai-connector
lhite8041 517693d
Added prompt to commands in 7 files, area Orchestrator
lhite8041 ef6b100
Added prompt to commands in 8 files, area orchestrator
lhite8041 3e9cc56
Added prompt to commands in 4 files, areas plugins, techdocs, upgrade
lhite8041 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,15 +3,15 @@ | |||||
| [id="proc-populating-the-api-definition-tab_{context}"] | ||||||
| = Populating the API Definition tab in {product-very-short} API entities | ||||||
|
|
||||||
| Since {rhoai-short} does not expose the OpenAPI specification by default, the AI platform engineer can take the following steps to provide this valuable information: | ||||||
| Because {rhoai-short} does not expose the OpenAPI specification by default, the AI platform engineer can take the following steps to provide this valuable information: | ||||||
|
|
||||||
| .Procedure | ||||||
|
|
||||||
| . Retrieve OpenAPI JSON: Use a tool like `curl` to fetch the specification directly from the running endpoint of the AI model server. The following command provides the precise endpoint (`/openapi.json`) and shows how to include a `Bearer` token if the model requires authentication for access. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| + | ||||||
| [source,bash] | ||||||
| ---- | ||||||
| curl -k -H "Authorization: Bearer $MODEL_API_KEY" https://$MODEL_ROOT_URL_INCLUDING_PORT/openapi.json | jq > open-api.json | ||||||
| $ curl -k -H "Authorization: Bearer $MODEL_API_KEY" https://$MODEL_ROOT_URL_INCLUDING_PORT/openapi.json | jq > open-api.json | ||||||
| ---- | ||||||
|
|
||||||
| . Set Property in {rhoai-short}. | ||||||
|
|
@@ -24,4 +24,4 @@ We recommend using *Model Version* instead of *Registered Model* to maintain sta | |||||
|
|
||||||
| .. In the **Properties** section, set a key/value pair where the key is `API Spec` and the value is the entire JSON content from the `open-api.json` file. | ||||||
|
|
||||||
| . Propagation: The {openshift-ai-connector-name} periodically polls the {rhoai-short} Model Registry, propagates this JSON, and renders the interactive API documentation in the *Definition* tab of the {product-very-short} API entity. | ||||||
| . Propagation: The {openshift-ai-connector-name} periodically polls the {rhoai-short} Model Registry, propagates this JSON, and renders the interactive API documentation in the *Definition* tab of the {product-very-short} API entity. | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ Validate that the dynamic plugins have been successfully installed into your {pr | |||||
|
|
||||||
| [source,bash,subs=+attributes] | ||||||
| ---- | ||||||
| oc logs -c install-dynamic-plugins deployment/<your {product-very-short} deployment> | ||||||
| $ oc logs -c install-dynamic-plugins deployment/<your {product-very-short} deployment> | ||||||
| ---- | ||||||
|
|
||||||
| The `install-dynamic-plugin` logs allow you to check the following installation logs for successful logs: | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
@@ -53,22 +53,22 @@ The {openshift-ai-connector-name-short} sidecars manage the data fetching and st | |||||
| + | ||||||
| [source,bash] | ||||||
| ---- | ||||||
| oc get configmap bac-import-model -o json | jq -r '.binaryData | to_entries[] | "=== \(.key) ===\n" + (.value | @base64d | fromjson | .body | @base64d | fromjson | tostring)' | jq -R 'if startswith("=== ") then . else (. | fromjson) end' | ||||||
| $ oc get configmap bac-import-model -o json | jq -r '.binaryData | to_entries[] | "=== \(.key) ===\n" + (.value | @base64d | fromjson | .body | @base64d | fromjson | tostring)' | jq -R 'if startswith("=== ") then . else (. | fromjson) end' | ||||||
| ---- | ||||||
|
|
||||||
| . Check Location Service API: Confirm the location service is providing data to the {product-very-short} Entity Provider. | ||||||
| + | ||||||
| [source,bash,subs=+attributes] | ||||||
| ---- | ||||||
| oc rsh -c backstage-backend deployment/<your {product-very-short} deployment> | ||||||
| curl http://localhost:9090/list | ||||||
| $ oc rsh -c backstage-backend deployment/<your {product-very-short} deployment> | ||||||
| $ curl http://localhost:9090/list | ||||||
| ---- | ||||||
|
|
||||||
| . Check Sidecar Container Logs: | ||||||
| + | ||||||
| [source,bash] | ||||||
| ---- | ||||||
| oc logs -c rhoai-normalizer deployment/<your {product-very-short} deployment> | ||||||
| oc logs -c storage-rest deployment/<your {product-very-short} deployment> | ||||||
| oc logs -c location deployment/<your {product-very-short} deployment> | ||||||
| $ oc logs -c rhoai-normalizer deployment/<your {product-very-short} deployment> | ||||||
| $ oc logs -c storage-rest deployment/<your {product-very-short} deployment> | ||||||
| $ oc logs -c location deployment/<your {product-very-short} deployment> | ||||||
| ---- | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.