Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Oct 4, 2024

Signed-off-by: Nick...

What does this PR do?

add RN text for 1.2.5

⚠️ Do not merge until 1.2.5 bits are released! ⚠️

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-4218

How to test this PR?

run the script, see the output, paste into the specified file.

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 4, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 4, 2024

@nickboldt nickboldt changed the title add RN text for 1.2.5 add RN text for 1.2.5 (RHIDP-4218) Oct 4, 2024
@nickboldt nickboldt marked this pull request as draft October 7, 2024 15:06
@nickboldt
Copy link
Member Author

@nickboldt nickboldt requested a review from kim-tsao October 7, 2024 15:30
@nickboldt
Copy link
Member Author

TODO: refactor to use similar filenames as in https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/596/files

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

Signed-off-by: Nick Boldt <[email protected]>

dedupe and add note about source of the freshmaker/RPM updates

Signed-off-by: Nick Boldt <[email protected]>
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 8, 2024

Signed-off-by: Nick Boldt <[email protected]>

switch to content from 1.2.5, including support for blank/comment lines

Signed-off-by: Nick Boldt <[email protected]>

remove embedded content for 1.2.5

Signed-off-by: Nick Boldt <[email protected]>

adjust spacing

Signed-off-by: Nick Boldt <[email protected]>

add notes about how the script changes in 1.3 version

Signed-off-by: Nick Boldt <[email protected]>

wrong indent

Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
@themr0c themr0c dismissed josephca’s stale review November 22, 2024 09:25

Added the missing description

@themr0c themr0c merged commit 98f1edb into 1.2.x Nov 22, 2024
1 of 2 checks passed
@themr0c themr0c deleted the rn_1.2.5 branch November 22, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants