Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 10, 2024

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1

Issue: https://issues.redhat.com/browse/RHIDP-1925

Link to docs preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-616/getting-started-rhdh/#_bulk-import-github-repositories

Reviews:

  • SME: @ mention assignee
  • QE: @ mention assignee
  • Docs review: @ mention assignee
  • Additional review: @mention assignee (by writer)

Additional information:

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 10, 2024

@themr0c themr0c force-pushed the RHIDP-1925-bulk-import-from-github branch from d68fec5 to dcca5c6 Compare October 11, 2024 11:19
@themr0c themr0c force-pushed the RHIDP-1925-bulk-import-from-github branch from dcca5c6 to 2b5660a Compare October 11, 2024 11:30
@themr0c themr0c requested a review from rm3l October 11, 2024 11:32
@rm3l
Copy link
Member

rm3l commented Oct 11, 2024

/cc @debsmita1

To take another look.

@themr0c themr0c marked this pull request as ready for review October 11, 2024 13:09
@themr0c themr0c requested a review from debsmita1 October 11, 2024 13:11
@themr0c
Copy link
Member Author

themr0c commented Oct 14, 2024

@rm3l All suggestions implemented. Can you review again.

@hmanwani-rh I believe you can start peer review.

@albarbaro I believe you can start QE review (or assign someone else).

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @themr0c !

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@hmanwani-rh hmanwani-rh merged commit 94d4dfc into redhat-developer:main Oct 17, 2024
2 checks passed
@hmanwani-rh
Copy link
Member

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #616 failed to apply on top of branch "release-1.3":

Applying: RHIDP-1925 bulk import from GitHub
.git/rebase-apply/patch:108: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	titles/getting-started-rhdh/title-getting-started.adoc
Falling back to patching base and 3-way merge...
Auto-merging titles/getting-started-rhdh/title-getting-started.adoc
CONFLICT (content): Merge conflict in titles/getting-started-rhdh/title-getting-started.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-1925 bulk import from GitHub

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: #616 failed to apply on top of branch "release-1.3":

Applying: RHIDP-1925 bulk import from GitHub
.git/rebase-apply/patch:108: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	titles/getting-started-rhdh/title-getting-started.adoc
Falling back to patching base and 3-way merge...
Auto-merging titles/getting-started-rhdh/title-getting-started.adoc
CONFLICT (content): Merge conflict in titles/getting-started-rhdh/title-getting-started.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-1925 bulk import from GitHub

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

themr0c added a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Oct 17, 2024
* RHIDP-1925 bulk import from GitHub

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* added YAML fragment

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update assemblies/assembly-bulk-importing-from-github.adoc

Co-authored-by: Armel Soro <[email protected]>

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

Co-authored-by: Armel Soro <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* RHIDP-1925 bulk import from GitHub

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update titles/getting-started-rhdh/title-getting-started.adoc

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

* Delete modules/importing-repositories/procedure-understanding-bulk-import-limitations.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

* Apply suggestions from code review

* chore: reuse technology preview content

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Apply suggestions from code review

Co-authored-by: Subhash Khileri <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Armel Soro <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Subhash Khileri <[email protected]>
themr0c added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Armel Soro <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Subhash Khileri <[email protected]>
@themr0c themr0c deleted the RHIDP-1925-bulk-import-from-github branch October 18, 2024 11:49
jmagak pushed a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Oct 30, 2024
* RHIDP-1925 bulk import from GitHub

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* added YAML fragment

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update assemblies/assembly-bulk-importing-from-github.adoc

Co-authored-by: Armel Soro <[email protected]>

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

Co-authored-by: Armel Soro <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* RHIDP-1925 bulk import from GitHub

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update titles/getting-started-rhdh/title-getting-started.adoc

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

* Delete modules/importing-repositories/procedure-understanding-bulk-import-limitations.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

* Update modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

* Update assemblies/assembly-bulk-importing-from-github.adoc

* Apply suggestions from code review

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Apply suggestions from code review

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

* Apply suggestions from code review

* chore: reuse technology preview content

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Apply suggestions from code review

Co-authored-by: Subhash Khileri <[email protected]>

* Update modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Armel Soro <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Subhash Khileri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants