-
Notifications
You must be signed in to change notification settings - Fork 57
RHIDP-4248 Finish removing authentication sections from GSG #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-4248 Finish removing authentication sections from GSG #620
Conversation
…tarted guide Signed-off-by: Fabrice Flore-Thébault <[email protected]>
…tarted guide Signed-off-by: Fabrice Flore-Thébault <[email protected]>
albarbaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. thanks!
|
/cherry-pick release-1.3 |
|
@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-620/ @ 10/17/24 07:10:42 |
…ctions-from-getting-started-guide
PatAKnight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well
…ctions-from-getting-started-guide
…ctions-from-getting-started-guide
|
@hmanwani-rh Good to merge. |
|
@themr0c Please rebase your branch |
…ctions-from-getting-started-guide
|
/cherry-pick release-1.3 |
|
@themr0c: #620 failed to apply on top of branch "release-1.3": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@themr0c Please cherry-pick to release-1.3 branch manually |
|
@hmanwani-rh: #620 failed to apply on top of branch "release-1.3": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…eveloper#620) * RHIDP-4248 Finish removing authentication sections from the Getting started guide Signed-off-by: Fabrice Flore-Thébault <[email protected]> * RHIDP-4248 Finish removing authentication sections from the Getting started guide Signed-off-by: Fabrice Flore-Thébault <[email protected]> * Update assemblies/assembly-authenticating-with-github.adoc * Update assemblies/assembly-authenticating-with-github.adoc --------- Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Finish removing authentication sections from the Getting started guide.
Only the
integrationsection was missing in the Authentication guide.All the rest has already been updated in the Authentication guide.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3.1
Issue: https://issues.redhat.com/browse/RHIDP-4248
Link to docs preview:
Reviews:
Additional information: