Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 15, 2024

Finish removing authentication sections from the Getting started guide.

Only the integration section was missing in the Authentication guide.

All the rest has already been updated in the Authentication guide.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1

Issue: https://issues.redhat.com/browse/RHIDP-4248

Link to docs preview:

Reviews:

  • SME: @ mention assignee
  • QE: @ mention assignee
  • Docs review: @ mention assignee
  • Additional review: @mention assignee (by writer)

Additional information:

@themr0c themr0c requested a review from hmanwani-rh October 15, 2024 09:51
@themr0c themr0c changed the title RHIDP-4248 Finish removing authentication sections from tGSG RHIDP-4248 Finish removing authentication sections from GSG Oct 15, 2024
Copy link
Member

@albarbaro albarbaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks!

@themr0c
Copy link
Member Author

themr0c commented Oct 15, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 15, 2024

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@themr0c
Copy link
Member Author

themr0c commented Oct 16, 2024

@hmanwani-rh Good to merge.

@hmanwani-rh
Copy link
Member

@themr0c Please rebase your branch

@hmanwani-rh hmanwani-rh merged commit a429ab7 into redhat-developer:main Oct 17, 2024
2 checks passed
@hmanwani-rh
Copy link
Member

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #620 failed to apply on top of branch "release-1.3":

Applying: RHIDP-4248 Finish removing authentication sections from the Getting started guide
.git/rebase-apply/patch:22: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/getting-started/proc-add-source-control-rhdh-catalog.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/getting-started/proc-add-source-control-rhdh-catalog.adoc deleted in RHIDP-4248 Finish removing authentication sections from the Getting started guide and modified in HEAD. Version HEAD of modules/getting-started/proc-add-source-control-rhdh-catalog.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-4248 Finish removing authentication sections from the Getting started guide

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hmanwani-rh
Copy link
Member

@themr0c Please cherry-pick to release-1.3 branch manually

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: #620 failed to apply on top of branch "release-1.3":

Applying: RHIDP-4248 Finish removing authentication sections from the Getting started guide
.git/rebase-apply/patch:22: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/getting-started/proc-add-source-control-rhdh-catalog.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/getting-started/proc-add-source-control-rhdh-catalog.adoc deleted in RHIDP-4248 Finish removing authentication sections from the Getting started guide and modified in HEAD. Version HEAD of modules/getting-started/proc-add-source-control-rhdh-catalog.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-4248 Finish removing authentication sections from the Getting started guide

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c themr0c deleted the RHIDP-4248-finish-removing-authentication-sections-from-getting-started-guide branch October 18, 2024 11:50
jmagak pushed a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Oct 30, 2024
…eveloper#620)

* RHIDP-4248 Finish removing authentication sections from the Getting started guide

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* RHIDP-4248 Finish removing authentication sections from the Getting started guide

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* Update assemblies/assembly-authenticating-with-github.adoc

* Update assemblies/assembly-authenticating-with-github.adoc

---------

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants