-
Notifications
You must be signed in to change notification settings - Fork 57
chore: removed unused Gitlab authentication procedure #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed unused Gitlab authentication procedure #623
Conversation
…tlab Signed-off-by: Fabrice Flore-Thébault <[email protected]>
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-623/ @ 10/16/24 12:07:00 |
|
/cherry-pick release-1.3 |
|
@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@themr0c We may need this section in the future when GitLab is supported. I suggest we keep the module but exclude it for now. |
|
The content has not been reworked along the authorization book revamp. We should not reintroduce it later in current state. |
What if we need the existing information? We can always revamp it into the desired state as needed. |
|
We can get the information back from history: this PR for example. Don't keep dead code in a project. It's confusing. |
|
@themr0c: new pull request created: #630 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…tlab (redhat-developer#623) Signed-off-by: Fabrice Flore-Thébault <[email protected]>
chore: removed unused and unsupported authentication procedure for Gittlab
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3.1
Issue:
Link to docs preview:
Reviews:
Additional information: