Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 15, 2024

chore: removed unused and unsupported authentication procedure for Gittlab

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1

Issue:

Link to docs preview:

Reviews:

  • SME: @ mention assignee
  • QE: @ mention assignee
  • Docs review: @ mention assignee
  • Additional review: @mention assignee (by writer)

Additional information:

@themr0c themr0c requested a review from hmanwani-rh October 15, 2024 12:21
@themr0c themr0c changed the title chore: removed unused and unsupported authentication procedure for Gi… chore: removed unused and unsupported authentication procedure Oct 15, 2024
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 15, 2024

@themr0c themr0c changed the title chore: removed unused and unsupported authentication procedure chore: removed unused Gitlab authentication procedure Oct 15, 2024
@themr0c
Copy link
Member Author

themr0c commented Oct 15, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hmanwani-rh
Copy link
Member

@themr0c We may need this section in the future when GitLab is supported. I suggest we keep the module but exclude it for now.

@themr0c
Copy link
Member Author

themr0c commented Oct 16, 2024

The content has not been reworked along the authorization book revamp. We should not reintroduce it later in current state.

@hmanwani-rh
Copy link
Member

The content has not been reworked along the authorization book revamp. We should not reintroduce it later in current state.

What if we need the existing information? We can always revamp it into the desired state as needed.

@themr0c
Copy link
Member Author

themr0c commented Oct 16, 2024

We can get the information back from history: this PR for example. Don't keep dead code in a project. It's confusing.

@hmanwani-rh hmanwani-rh merged commit aa83e72 into redhat-developer:main Oct 16, 2024
2 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #630

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c themr0c deleted the remove-unused-auth-module branch October 18, 2024 11:50
jmagak pushed a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants