Skip to content

RHIDP-1925 Fix GitHub integration procedure #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gerry-Forde merged 9 commits into from
Nov 4, 2024
Merged

RHIDP-1925 Fix GitHub integration procedure #646

Gerry-Forde merged 9 commits into from
Nov 4, 2024

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 18, 2024 •
edited
Loading

@rm3l said:

I think the most important prerequisite for Bulk Import is to configure one or more GH integrations. It doesn't rely on GH authentication.
Also, the link points to Enabling authentication with GitHub, but there is nowhere in this page how to configure a GH integration

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1

Issue: https://issues.redhat.com/browse/RHIDP-1925

Link to docs preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-646/authentication/#enabling-authentication-with-github

Reviews:

Additional information:

@themr0c
fix leftovers
fdb3c14 
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c
fix erroneous procedure
f7272e5 
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c themr0c changed the title fix leftovers Fix GitHub integration procedure Oct 18, 2024
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 18, 2024 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-646/ @ 11/04/24 08:31:42

@themr0c themr0c requested review from hmanwani-rh and rm3l October 18, 2024 12:17
@themr0c
Copy link
Member Author

themr0c commented Oct 18, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Oct 18, 2024

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c
more fixup
5355f83 
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@josephca
Copy link
Member

josephca commented Oct 18, 2024

@subhashkhileri please provide a review, thanks!

@themr0c themr0c requested a review from jmagak October 21, 2024 10:26
themr0c
themr0c commented Oct 21, 2024
View reviewed changes
hmanwani-rh
hmanwani-rh reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themr0c Few comments below. Please take a look and let me know if you've any questions.

@themr0c themr0c changed the title Fix GitHub integration procedure RHIDP-1925 Fix GitHub integration procedure Oct 22, 2024
@hmanwani-rh
Copy link
Member

hmanwani-rh commented Oct 23, 2024

@themr0c This PR needs rebasing.

@Gerry-Forde Gerry-Forde merged commit 13b75ef into redhat-developer:main Nov 4, 2024
2 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 4, 2024

@themr0c: new pull request created: #666

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2024
Merged
@themr0c themr0c deleted the fix-github-integration branch November 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmanwani-rh hmanwani-rh hmanwani-rh approved these changes

@jmagak jmagak Awaiting requested review from jmagak

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

+1 more reviewer

@rm3l rm3l rm3l approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@themr0c @rhdh-bot @openshift-cherrypick-robot @josephca @hmanwani-rh @rm3l @subhashkhileri @Gerry-Forde