Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Oct 22, 2024

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.1, 1.4

Issue: https://issues.redhat.com/browse/RHIDP-4533

Link to docs preview:

Reviews:

  • SME: @ mention assignee
  • QE: @ mention assignee
  • Docs review: @ mention assignee
  • Additional review: @pabel-rh

Additional information:

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 22, 2024

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c
Copy link
Member Author

themr0c commented Nov 4, 2024

Note: the action was failing when using

with:
  token: ${{secrets.VALE_GITHUB_TOKEN}}

rather than the env section. Reverted back.

@nickboldt
Copy link
Member

Seems OK but I'd prefer to wait on this until after the 1.4 branches are created so we can keep doing doc in case this breaks anything, eg., with your deleted symlinks?

@Gerry-Forde Gerry-Forde merged commit cec31da into redhat-developer:main Nov 4, 2024
3 checks passed
Gerry-Forde added a commit that referenced this pull request Nov 4, 2024
Gerry-Forde added a commit that referenced this pull request Nov 4, 2024
@Gerry-Forde
Copy link
Member

@themr0c I had just merged this PR but then saw @nickboldt most recent comment. I reverted the merge, can you please clarify if this should be merged or not now considering Nick's comment?

@nickboldt
Copy link
Member

It's fine, leave it. If it doesn't break PR checks and pushes to Pantheon, I'm good with it.

@themr0c themr0c deleted the check-for-style branch November 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants