-
Notifications
You must be signed in to change notification settings - Fork 57
RHIDP-4533 test documentation for style in GitHub pull requests #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-649/ @ 11/04/24 14:50:32 |
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
|
Note: the action was failing when using rather than the env section. Reverted back. |
|
Seems OK but I'd prefer to wait on this until after the 1.4 branches are created so we can keep doing doc in case this breaks anything, eg., with your deleted symlinks? |
|
@themr0c I had just merged this PR but then saw @nickboldt most recent comment. I reverted the merge, can you please clarify if this should be merged or not now considering Nick's comment? |
|
It's fine, leave it. If it doesn't break PR checks and pushes to Pantheon, I'm good with it. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3.1, 1.4
Issue: https://issues.redhat.com/browse/RHIDP-4533
Link to docs preview:
Reviews:
Additional information: