Skip to content

Conversation

@jmagak
Copy link
Member

@jmagak jmagak commented Oct 29, 2024

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.4

Issue: (https://issues.redhat.com/browse/RHIDP-4699)](https://issues.redhat.com/browse/RHIDP-4699)

Link to docs preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-661/about/#supported-platforms_about-rhdh

Reviews:

Additional information:

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 29, 2024

@jmagak jmagak marked this pull request as draft October 30, 2024 08:14
@dzemanov
Copy link
Member

Looks good to me!

@jmagak jmagak requested review from dzemanov and pabel-rh October 30, 2024 08:34
@jmagak jmagak force-pushed the RHIDP-4699-Discover-Add-supported-platforms-to-the-About/Discover-section branch from 00cf330 to 4932894 Compare November 5, 2024 14:14
@themr0c
Copy link
Member

themr0c commented Nov 6, 2024

I believe you force-pushed by mistake the content intended for #663.

@jmagak jmagak force-pushed the RHIDP-4699-Discover-Add-supported-platforms-to-the-About/Discover-section branch from 9d146b7 to 4e6099b Compare November 8, 2024 13:21
@jmagak jmagak requested a review from themr0c November 8, 2024 13:26
@jmagak jmagak force-pushed the RHIDP-4699-Discover-Add-supported-platforms-to-the-About/Discover-section branch from fdb81c9 to 5caa1d8 Compare November 25, 2024 12:21
@jmagak
Copy link
Member Author

jmagak commented Nov 25, 2024

@themr0c , please assist me in reviewing these changes.

@themr0c themr0c marked this pull request as ready for review November 27, 2024 10:48
@themr0c themr0c merged commit 9104adb into redhat-developer:main Nov 27, 2024
5 checks passed
@themr0c
Copy link
Member

themr0c commented Nov 27, 2024

I merged by accident. @jmagak can you check with QE?

/cherry-pick release-1.4

@themr0c
Copy link
Member

themr0c commented Nov 27, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #740

In response to this:

I merged by accident. @jmagak can you check with QE?

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #661 failed to apply on top of branch "release-1.3":

Applying: Updates supported platforms
Using index info to reconstruct a base tree...
M	artifacts/attributes.adoc
Falling back to patching base and 3-way merge...
Auto-merging artifacts/attributes.adoc
CONFLICT (content): Merge conflict in artifacts/attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Updates supported platforms

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@zdrapela zdrapela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm missing GKE on the list. It is tested and supported from 1.4.

@jmagak
Copy link
Member Author

jmagak commented Nov 27, 2024

Hi, I'm missing GKE on the list. It is tested and supported from 1.4.

Sorry, just to clarify, is that Google Kubernetes Engine?

@jmagak jmagak mentioned this pull request Nov 27, 2024
@nickboldt
Copy link
Member

Hi, I'm missing GKE on the list. It is tested and supported from 1.4.

Sorry, just to clarify, is that Google Kubernetes Engine?

https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/blob/main/artifacts/attributes.adoc#L50-L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants