Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 6, 2024

What does this PR do?

chore(dynamic plugin version checking): quieter output when the versions match

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt changed the title quieter output when the versions... quieter output when the versions match Nov 6, 2024
@nickboldt nickboldt changed the title quieter output when the versions match chore(dynamic plugin version checking): quieter output when the versions match Nov 6, 2024
@nickboldt
Copy link
Member Author

nickboldt commented Nov 6, 2024

Instead of warnings that we're using version x.y.z instead of x.y.z, suppress those pointless warnings and empty lines so the warnings are cleaner and easier to address. Related to release of 1.3.1 (RHIDP-4343)

manual partial cherrypick of #643 but for main branch

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 6, 2024

@themr0c
Copy link
Member

themr0c commented Nov 7, 2024

Side note: yq (Python version, not Go version) requirement is not mentioned:

ModuleNotFoundError: No module named 'yq'

@themr0c
Copy link
Member

themr0c commented Nov 7, 2024

Nitpicks from a first time user of this script.

The help says:

Generate updated table of dynamic plugins from content in janus-idp/backstage-plugins and backstage-showcase repos, for the specified branch

-b, --ref-branch : Reference branch against which plugin versions should be incremented, like 1.1.x or main

But I assume 1.1.x is an obsolete branch name.

Reading this, I needed to:

  1. Search the actual URL of both repositories.
  2. Look at the repositories to identify the available branch names.
  3. Choose the correct branch name. I guessed it is release-1.3 because we use the same naming convention in this repository.

I would appreciate that the help:

  • Displays the full URL of both repositories.
  • Displays available branch names.
  • Displays a hint for the branch name that makes most sense in my current situation (release-1.3)

@Gerry-Forde Gerry-Forde merged commit bb5b02a into main Nov 7, 2024
3 checks passed
@Gerry-Forde Gerry-Forde deleted the quieter-ouput_main branch November 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants