Skip to content

chore(dynamic plugin version checking): quieter output when the versions match #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(dynamic plugin version checking): quieter output when the versions match #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/dynamic-plugins/rhdh-supported-plugins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ for j in $jsons; do
Version=$VersionJQ
if [[ $match ]]; then
Version=$(echo "${match}" | sed -r -e "s/.+\": \"([0-9.]+)\"/\1/")
echo "[WARN] !! Using $pluginVersFile version = $Version, not $VersionJQ from $Path" | tee -a /tmp/warnings.txt
if [[ "$Version" != "$VersionJQ" ]]; then
echo "[WARN] !! Using $pluginVersFile version = $Version, not $VersionJQ from $Path" | tee -a /tmp/warnings.txt
fi
fi

# check if there's a newer version at npmjs.com and warn if so
Expand All @@ -163,7 +165,7 @@ for j in $jsons; do
echo "[DEBUG] Latest x.y version at https://registry.npmjs.org/${Plugin/\//%2f} : $latestXYRelease"
if [[ "$latestXYRelease" != "$Version" ]]; then
echo "[WARN] !! Newer $latestXYRelease > $Version - should upgrade to https://www.npmjs.com/package/$Plugin/v/$latestXYRelease !!" | tee -a /tmp/warnings.txt
echo | tee -a /tmp/warnings.txt
# echo | tee -a /tmp/warnings.txt
fi

# default to community unless it's a RH-authored plugin
Expand Down