RHIDP-4566: document how to manage PVCs in RHDH operator #702

hmanwani-rh · 2024-11-13T09:20:55Z

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.4

Issue:
RHIDP-4566

Link to docs preview:
Find the link within the PR

Reviews:

SME: @rm3l
QE: @Omar-AlJaljuli
Docs review: @omajid
Additional review: @mention assignee (by writer)

Additional information:

rhdh-bot · 2024-11-13T09:23:00Z

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-702/ @ 12/04/24 12:40:12

modules/admin/proc-rhdh-deployment-config.adoc

hmanwani-rh · 2024-11-20T07:53:54Z

@rm3l @gazarenkov I've incorporated the suggestions. Could you please review one more time and share your approval?

modules/admin/proc-mount-directories-pvcs.adoc

rm3l

LGTM otherwise. Thanks.

josephca · 2024-11-22T14:43:33Z

Hi @Omar-AlJaljuli, can you provide the review? thanks!

omajid · 2024-11-22T17:11:23Z

Hey! Was @'ing me a mistake? I am not a documentation writer, nor familiar with this project Are you actually looking for a review from me?

modules/admin/proc-mount-directories-pvcs.adoc

Omar-AlJaljuli

/lgtm

hmanwani-rh · 2024-12-04T14:56:33Z

/cherry-pick release-1.4

openshift-cherrypick-robot · 2024-12-04T14:56:36Z

@hmanwani-rh: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-12-04T15:13:50Z

@hmanwani-rh: new pull request created: #768

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Gerry-Forde · 2024-12-04T15:14:19Z

/cherrypick release-1.4

openshift-cherrypick-robot · 2024-12-04T15:14:57Z

@Gerry-Forde: new pull request could not be created: failed to create pull request against redhat-developer/red-hat-developers-documentation-rhdh#release-1.4 from head openshift-cherrypick-robot:cherry-pick-702-to-release-1.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-702-to-release-1.4."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…loper#702) * RHIDP-4566: document how to manage PVCs in RHDH operator * Incorporated review suggestions * Incorporate QE suggestion

…nctions to proxy backend (#766) * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend * RHIDP-4566: document how to manage PVCs in RHDH operator (#702) * RHIDP-4566: document how to manage PVCs in RHDH operator * Incorporated review suggestions * Incorporate QE suggestion * chore: dynamic plugins are all now expressed as wrappers (RHIDP-5103) (#753) * chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore Signed-off-by: Nick Boldt <[email protected]> * comment out the TP stuff and mark it with RHIDP-5103 so we can re-enable it if needed in future Signed-off-by: Nick Boldt <[email protected]> * regen content from showcase main branch Signed-off-by: Nick Boldt <[email protected]> * re-add missing community plugins Signed-off-by: Nick Boldt <[email protected]> * re-add missing community plugins (regen content) Signed-off-by: Nick Boldt <[email protected]> --------- Signed-off-by: Nick Boldt <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> * RHIDP-4409: update metric monitoring instructions for OCP and AKS (#757) * update metric monitoring instructions for OCP and AKS Signed-off-by: Jessica He <[email protected]> * modularized the content --------- Signed-off-by: Jessica He <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Heena Manwani <[email protected]> * added missing article (#741) * chore: fix known issues search string (#774) Signed-off-by: Fabrice Flore-Thébault <[email protected]> * RHIDP-4805: RHBK v24 support for RHDH 1.4 (#767) * RHBK v24 support for RHDH 1.4 * Added note * review suggestions incorporated * RHIDP-4572: Updating /metrics port (#735) Co-authored-by: Fabrice Flore-Thébault <[email protected]> * chore(installation): remove non-OLM installation doc; add link to OLM quickstart (RHIDP-2707) (RHIDP-3497) (#700) * chore(installation): remove doc about non-OLM instlalation method; add extra link to OLM quickstart at https://olm.operatorframework.io/docs/getting-started/ (RHIDP-2707) (RHIDP-3497) Signed-off-by: Nick Boldt <[email protected]> * Update modules/installation/proc-rhdh-deploy-eks-operator.adoc Co-authored-by: Heena Manwani <[email protected]> --------- Signed-off-by: Nick Boldt <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Add supported keycloak version * Remove Audit log file rotation in RHDH * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend --------- Signed-off-by: Nick Boldt <[email protected]> Signed-off-by: Jessica He <[email protected]> Signed-off-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Nick Boldt <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Jessica He <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Priyanka Abel <[email protected]> Co-authored-by: jmagak <[email protected]>

…nctions to proxy backend (redhat-developer#766) * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend * RHIDP-4566: document how to manage PVCs in RHDH operator (redhat-developer#702) * RHIDP-4566: document how to manage PVCs in RHDH operator * Incorporated review suggestions * Incorporate QE suggestion * chore: dynamic plugins are all now expressed as wrappers (RHIDP-5103) (redhat-developer#753) * chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore Signed-off-by: Nick Boldt <[email protected]> * comment out the TP stuff and mark it with RHIDP-5103 so we can re-enable it if needed in future Signed-off-by: Nick Boldt <[email protected]> * regen content from showcase main branch Signed-off-by: Nick Boldt <[email protected]> * re-add missing community plugins Signed-off-by: Nick Boldt <[email protected]> * re-add missing community plugins (regen content) Signed-off-by: Nick Boldt <[email protected]> --------- Signed-off-by: Nick Boldt <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> * RHIDP-4409: update metric monitoring instructions for OCP and AKS (redhat-developer#757) * update metric monitoring instructions for OCP and AKS Signed-off-by: Jessica He <[email protected]> * modularized the content --------- Signed-off-by: Jessica He <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Heena Manwani <[email protected]> * added missing article (redhat-developer#741) * chore: fix known issues search string (redhat-developer#774) Signed-off-by: Fabrice Flore-Thébault <[email protected]> * RHIDP-4805: RHBK v24 support for RHDH 1.4 (redhat-developer#767) * RHBK v24 support for RHDH 1.4 * Added note * review suggestions incorporated * RHIDP-4572: Updating /metrics port (redhat-developer#735) Co-authored-by: Fabrice Flore-Thébault <[email protected]> * chore(installation): remove non-OLM installation doc; add link to OLM quickstart (RHIDP-2707) (RHIDP-3497) (redhat-developer#700) * chore(installation): remove doc about non-OLM instlalation method; add extra link to OLM quickstart at https://olm.operatorframework.io/docs/getting-started/ (RHIDP-2707) (RHIDP-3497) Signed-off-by: Nick Boldt <[email protected]> * Update modules/installation/proc-rhdh-deploy-eks-operator.adoc Co-authored-by: Heena Manwani <[email protected]> --------- Signed-off-by: Nick Boldt <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Add supported keycloak version * Remove Audit log file rotation in RHDH * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend * RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend --------- Signed-off-by: Nick Boldt <[email protected]> Signed-off-by: Jessica He <[email protected]> Signed-off-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Nick Boldt <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: Jessica He <[email protected]> Co-authored-by: Heena Manwani <[email protected]> Co-authored-by: Priyanka Abel <[email protected]> Co-authored-by: jmagak <[email protected]>

hmanwani-rh temporarily deployed to external November 13, 2024 09:21 — with GitHub Actions Inactive

hmanwani-rh requested a review from rm3l November 13, 2024 09:21

hmanwani-rh added the do-no-merge/review-in-progress 👀 label Nov 13, 2024

gazarenkov suggested changes Nov 13, 2024

View reviewed changes

modules/admin/proc-rhdh-deployment-config.adoc Outdated Show resolved Hide resolved

modules/admin/proc-rhdh-deployment-config.adoc Outdated Show resolved Hide resolved

rm3l reviewed Nov 13, 2024

View reviewed changes

modules/admin/proc-rhdh-deployment-config.adoc Outdated Show resolved Hide resolved

modules/admin/proc-rhdh-deployment-config.adoc Outdated Show resolved Hide resolved

rm3l reviewed Nov 13, 2024

View reviewed changes

modules/admin/proc-rhdh-deployment-config.adoc Outdated Show resolved Hide resolved

themr0c added Peer review needed 📖 QE review needed 🔧 Technical review needed 🔩 Test all the procedures labels Nov 14, 2024

hmanwani-rh removed Peer review needed 📖 QE review needed 🔧 Technical review needed 🔩 Test all the procedures labels Nov 20, 2024

hmanwani-rh force-pushed the RHIDP-4566-main branch from f1bde16 to 385463d Compare November 20, 2024 07:27

hmanwani-rh temporarily deployed to external November 20, 2024 07:27 — with GitHub Actions Inactive

hmanwani-rh temporarily deployed to external November 20, 2024 07:55 — with GitHub Actions Inactive

rm3l reviewed Nov 21, 2024

View reviewed changes

modules/admin/proc-mount-directories-pvcs.adoc Show resolved Hide resolved

rm3l approved these changes Nov 21, 2024

View reviewed changes

hmanwani-rh temporarily deployed to external November 21, 2024 12:15 — with GitHub Actions Inactive

rm3l approved these changes Nov 21, 2024

View reviewed changes

josephca temporarily deployed to external November 22, 2024 16:36 — with GitHub Actions Inactive

themr0c added Peer review needed 📖 QE review needed 🔧 Technical review needed 🔩 Test all the procedures labels Nov 28, 2024

themr0c temporarily deployed to external November 28, 2024 09:01 — with GitHub Actions Inactive

pabel-rh approved these changes Nov 28, 2024

View reviewed changes

pabel-rh added the Peer review done 📘 label Nov 28, 2024

themr0c temporarily deployed to external December 3, 2024 13:31 — with GitHub Actions Inactive

Omar-AlJaljuli reviewed Dec 3, 2024

View reviewed changes

modules/admin/proc-mount-directories-pvcs.adoc Outdated Show resolved Hide resolved

hmanwani-rh added 2 commits December 4, 2024 18:04

RHIDP-4566: document how to manage PVCs in RHDH operator

fb6fcf1

Incorporated review suggestions

45e8a9a

hmanwani-rh force-pushed the RHIDP-4566-main branch from 763c4e7 to 45e8a9a Compare December 4, 2024 12:35

hmanwani-rh temporarily deployed to external December 4, 2024 12:35 — with GitHub Actions Inactive

Incorporate QE suggestion

6805d4e

hmanwani-rh temporarily deployed to external December 4, 2024 12:37 — with GitHub Actions Inactive

Omar-AlJaljuli approved these changes Dec 4, 2024

View reviewed changes

openshift-ci bot assigned Omar-AlJaljuli Dec 4, 2024

openshift-ci bot added the lgtm label Dec 4, 2024

Gerry-Forde merged commit 108397c into redhat-developer:main Dec 4, 2024
3 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 4, 2024

[release-1.4] RHIDP-4566: document how to manage PVCs in RHDH operator #768

Merged

RHIDP-4566: document how to manage PVCs in RHDH operator #702

RHIDP-4566: document how to manage PVCs in RHDH operator #702

Uh oh!

Conversation

hmanwani-rh commented Nov 13, 2024 • edited by josephca Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhdh-bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hmanwani-rh commented Nov 20, 2024

Uh oh!

Uh oh!

rm3l left a comment

Choose a reason for hiding this comment

Uh oh!

josephca commented Nov 22, 2024

Uh oh!

omajid commented Nov 22, 2024

Uh oh!

Uh oh!

Omar-AlJaljuli left a comment

Choose a reason for hiding this comment

Uh oh!

hmanwani-rh commented Dec 4, 2024

Uh oh!

openshift-cherrypick-robot commented Dec 4, 2024

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 4, 2024

Uh oh!

Gerry-Forde commented Dec 4, 2024

Uh oh!

openshift-cherrypick-robot commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

hmanwani-rh commented Nov 13, 2024 •

edited by josephca

Loading

rhdh-bot commented Nov 13, 2024 •

edited

Loading