-
Notifications
You must be signed in to change notification settings - Fork 57
RHIDP-4862 - Update Tech Radar to 1.0 #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-708/ @ 11/26/24 06:35:47 |
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
|
Can you change this line: https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/708/files#diff-04ff043450b84f23201d528293ad4455bd713bb6bedc0614b4788bc673628589R4 to In {product}, the Tech Radar page is provided by the |
04kash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few comments
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
|
@gustavolira can you provide a review? thanks! |
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
modules/getting-started/proc-customize-rhdh-tech-radar-page.adoc
Outdated
Show resolved
Hide resolved
|
@pabel-rh I’ve added a comment—could you please address it and rebase the branch? Once that’s done, we can move forward with merging this PR. |
* Incorporated changes * incorporated kashish's comment * comments
* Incorporated changes * incorporated kashish's comment * comments
|
/cherry-pick release-1.4 |
|
@themr0c: #708 failed to apply on top of branch "release-1.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Issue: RHIDP-4862
Link to docs preview:
Reviews:
Additional information: