Skip to content

Updated about RHDH and added RHTAP content #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

Updated about RHDH and added RHTAP content #724

merged 1 commit into from
Dec 18, 2024

Conversation

@gtrivedi88
Copy link
Contributor

@gtrivedi88 gtrivedi88 commented Nov 20, 2024 •
edited
Loading

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

In this PR:

  • I restructured about RHDH content
  • Added content around RHTAP
  • Renamed Discover to About at a couple of places
  • Updated attributes to add references for RHTAP

Version(s): RHDH 1.4 and RHTAP 1.3

Issue:
HACDOCS-1118

Output:
About

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 20, 2024 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-724/ @ 12/16/24 12:18:18

nickboldt
nickboldt reviewed Nov 25, 2024
View reviewed changes
nickboldt
nickboldt reviewed Nov 25, 2024
View reviewed changes
@gtrivedi88 gtrivedi88 closed this Nov 26, 2024
@gtrivedi88 gtrivedi88 reopened this Nov 26, 2024
@themr0c themr0c requested a review from jmagak November 28, 2024 08:28
jmagak
jmagak reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Other than that, lgtm.

hmanwani-rh
hmanwani-rh reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrivedi88 I’ve added a few comments, and there’s also a note from Vale that might be worth considering.

@hmanwani-rh
Copy link
Member

hmanwani-rh commented Dec 16, 2024

@durandom Could you please review the content in the PR? It covers information about RHDH and its relationship with other platforms.

@hmanwani-rh hmanwani-rh requested a review from durandom December 16, 2024 14:00
durandom
durandom approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@hmanwani-rh
Copy link
Member

hmanwani-rh commented Dec 18, 2024

Received Christophe's lgtm, thus merging this PR.

@hmanwani-rh hmanwani-rh merged commit b8d6973 into redhat-developer:main Dec 18, 2024
3 checks passed
@hmanwani-rh
Copy link
Member

hmanwani-rh commented Dec 18, 2024

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Dec 18, 2024

@hmanwani-rh: new pull request created: #813

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2024
Merged
otikhomi pushed a commit to otikhomi/red-hat-developers-documentation-rhdh that referenced this pull request Jan 20, 2025
@gtrivedi88 @themr0c @otikhomi
chore: ccutil to use the article doctype (redhat-developer#763) (redh…
a413f41 
…at-developer#724)

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickboldt nickboldt nickboldt left review comments

@jmagak jmagak jmagak left review comments

@hmanwani-rh hmanwani-rh hmanwani-rh approved these changes

+2 more reviewers

@Preeticp Preeticp Preeticp left review comments

@durandom durandom durandom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@durandom durandom

Labels

Peer review done 📘 Technical review needed 🔩 Test all the procedures

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@gtrivedi88 @rhdh-bot @hmanwani-rh @openshift-cherrypick-robot @durandom @nickboldt @Preeticp @jmagak @themr0c