Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 28, 2024

What does this PR do?

chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore

This PR is for 1.4 branch

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-5103

for 1.4: #754
for main: #753

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 28, 2024

@nickboldt nickboldt changed the title regen content from showcase release-1.4... chore: dynamic plugins are all now expressed as wrappers (RHIDP-5103) Nov 28, 2024
@nickboldt nickboldt requested a review from themr0c November 28, 2024 17:13
Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be merged so that we can run the content generation script locally and make any further content changes if necessary.

@themr0c themr0c merged commit 68c0e94 into release-1.4 Dec 4, 2024
3 checks passed
@themr0c themr0c deleted the dedupe-janus-plugins-and-janus-showcase-wrappers_14 branch December 4, 2024 16:10
jmagak pushed a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Dec 17, 2024
…redhat-developer#754)

* chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore

Signed-off-by: Nick Boldt <[email protected]>

* comment out the TP stuff and mark it with RHIDP-5103 so we can re-enable it if needed in future

Signed-off-by: Nick Boldt <[email protected]>

* regen content from showcase release-1.4 branch

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins (regen content)

Signed-off-by: Nick Boldt <[email protected]>

---------

Signed-off-by: Nick Boldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants