Skip to content

Conversation

@Gerry-Forde
Copy link
Member

RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.4

Add the relevant labels to the Pull Request.
Issue:
RHIDP-4802

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Dec 4, 2024

hmanwani-rh and others added 2 commits December 4, 2024 17:14
…loper#702)

* RHIDP-4566: document how to manage PVCs in RHDH operator

* Incorporated review suggestions

* Incorporate QE suggestion
…redhat-developer#753)

* chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore

Signed-off-by: Nick Boldt <[email protected]>

* comment out the TP stuff and mark it with RHIDP-5103 so we can re-enable it if needed in future

Signed-off-by: Nick Boldt <[email protected]>

* regen content from showcase main branch

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins (regen content)

Signed-off-by: Nick Boldt <[email protected]>

---------

Signed-off-by: Nick Boldt <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
JessicaJHee and others added 9 commits December 12, 2024 11:06
…dhat-developer#757)

* update metric monitoring instructions for OCP and AKS

Signed-off-by: Jessica He <[email protected]>

* modularized the content

---------

Signed-off-by: Jessica He <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
* RHBK v24 support for RHDH 1.4

* Added note

* review suggestions incorporated
… quickstart (RHIDP-2707) (RHIDP-3497) (redhat-developer#700)

* chore(installation): remove doc about non-OLM instlalation method; add extra link to OLM quickstart at https://olm.operatorframework.io/docs/getting-started/ (RHIDP-2707) (RHIDP-3497)

Signed-off-by: Nick Boldt <[email protected]>

* Update modules/installation/proc-rhdh-deploy-eks-operator.adoc

Co-authored-by: Heena Manwani <[email protected]>

---------

Signed-off-by: Nick Boldt <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
@Gerry-Forde
Copy link
Member Author

@gashcrumb Could you please provide a SME review for this PR? Is it correct to say that the relevant environment variable should be set to true to override a statically implemented service?

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gerry-Forde Gerry-Forde added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Dec 16, 2024
@Gerry-Forde Gerry-Forde merged commit 2ae0162 into redhat-developer:main Dec 16, 2024
3 checks passed
@Gerry-Forde
Copy link
Member Author

/cherrypick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@Gerry-Forde: #766 failed to apply on top of branch "release-1.4":

Applying: RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend
.git/rebase-apply/patch:30: trailing whitespace.
The {product} ({product-very-short}) backend platform consists of a number of core services that are well encapsulated.  The {product-very-short} backend installs these default core services statically during initialization. 
.git/rebase-apply/patch:80: trailing whitespace.
| `ENABLE_CORE_CACHE_OVERRIDE` 
.git/rebase-apply/patch:83: trailing whitespace.
| `ENABLE_CORE_ROOTCONFIG_OVERRIDE` 
.git/rebase-apply/patch:86: trailing whitespace.
| `ENABLE_CORE_DATABASE_OVERRIDE` 
.git/rebase-apply/patch:89: trailing whitespace.
| `ENABLE_CORE_DISCOVERY_OVERRIDE` 
warning: squelched 12 whitespace errors
warning: 17 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	assemblies/dynamic-plugins/assembly-configuring-rhdh-plugins.adoc
Falling back to patching base and 3-way merge...
Auto-merging assemblies/dynamic-plugins/assembly-configuring-rhdh-plugins.adoc
CONFLICT (content): Merge conflict in assemblies/dynamic-plugins/assembly-configuring-rhdh-plugins.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

otikhomi pushed a commit to otikhomi/red-hat-developers-documentation-rhdh that referenced this pull request Jan 20, 2025
…nctions to proxy backend (redhat-developer#766)

* RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend

* RHIDP-4566: document how to manage PVCs in RHDH operator (redhat-developer#702)

* RHIDP-4566: document how to manage PVCs in RHDH operator

* Incorporated review suggestions

* Incorporate QE suggestion

* chore: dynamic plugins are all now expressed as wrappers (RHIDP-5103) (redhat-developer#753)

* chore: dynamic plugins are all now expressed as wrappers so we don't need to parse janus-plugins repo anymore

Signed-off-by: Nick Boldt <[email protected]>

* comment out the TP stuff and mark it with RHIDP-5103 so we can re-enable it if needed in future

Signed-off-by: Nick Boldt <[email protected]>

* regen content from showcase main branch

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins

Signed-off-by: Nick Boldt <[email protected]>

* re-add missing community plugins (regen content)

Signed-off-by: Nick Boldt <[email protected]>

---------

Signed-off-by: Nick Boldt <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* RHIDP-4409: update metric monitoring instructions for OCP and AKS (redhat-developer#757)

* update metric monitoring instructions for OCP and AKS

Signed-off-by: Jessica He <[email protected]>

* modularized the content

---------

Signed-off-by: Jessica He <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>

* added missing article (redhat-developer#741)

* chore: fix known issues search string (redhat-developer#774)

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

* RHIDP-4805: RHBK v24 support for RHDH 1.4 (redhat-developer#767)

* RHBK v24 support for RHDH 1.4

* Added note

* review suggestions incorporated

* RHIDP-4572: Updating /metrics port (redhat-developer#735)

Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* chore(installation): remove non-OLM installation doc; add link to OLM quickstart (RHIDP-2707) (RHIDP-3497) (redhat-developer#700)

* chore(installation): remove doc about non-OLM instlalation method; add extra link to OLM quickstart at https://olm.operatorframework.io/docs/getting-started/ (RHIDP-2707) (RHIDP-3497)

Signed-off-by: Nick Boldt <[email protected]>

* Update modules/installation/proc-rhdh-deploy-eks-operator.adoc

Co-authored-by: Heena Manwani <[email protected]>

---------

Signed-off-by: Nick Boldt <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>

* Add supported keycloak version

* Remove Audit log file rotation in RHDH

* RHIDP-4802 -  Dynamic plugin: Document how users can add middleware functions to proxy backend

* RHIDP-4802 - Dynamic plugin: Document how users can add middleware functions to proxy backend

---------

Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Jessica He <[email protected]>
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>
Co-authored-by: Jessica He <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Co-authored-by: Priyanka Abel <[email protected]>
Co-authored-by: jmagak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants