-
Notifications
You must be signed in to change notification settings - Fork 58
RHIDP-5373: Setting baseUrl #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-5373: Setting baseUrl #876
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-876/ @ 01/27/25 14:58:19 |
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
9ee25ab to
998869f
Compare
kadel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue mentioned that the information about baseUrl should be part of the installation process, not just in the customization or configuration section.
The problem is that users following the installation guide end up at the end of the process with an incorrectly working instance without baseUrl properly configured
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/proc-provisioning-your-custom-configuration.adoc
Outdated
Show resolved
Hide resolved
|
@kadel My understanding is that every installation guide should point to https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.4/html/configuring/provisioning-and-using-your-custom-configuration, as a custom config map is mandatory. This PR is the first step: make the mandatory field visible in https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-876/configuring/#provisioning-your-custom-configuration |
…to-be-part-of-the-Installation-guide
|
@kadel Can we merge this PR already, and adress the rest in subsequent pull requests? |
|
/cherry-pick release-1.4 |
|
@themr0c: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kadel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this, it makes things a little bit better, but I don't think that this solves the https://issues.redhat.com/browse/RHIDP-5373 issue
|
@themr0c: new pull request created: #884 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5373