Skip to content

Conversation

@jmagak
Copy link
Member

@jmagak jmagak commented Jan 24, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.4

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5373

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 24, 2025

@jmagak jmagak changed the title Setting baseUrl RHIDP-5373: Setting baseUrl Jan 24, 2025
@jmagak jmagak force-pushed the RHIDP-5373-info-about-setting-baseUrl-needs-to-be-part-of-the-Installation-guide branch from 9ee25ab to 998869f Compare January 24, 2025 16:46
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue mentioned that the information about baseUrl should be part of the installation process, not just in the customization or configuration section.

The problem is that users following the installation guide end up at the end of the process with an incorrectly working instance without baseUrl properly configured

@themr0c
Copy link
Member

themr0c commented Jan 27, 2025

@kadel My understanding is that every installation guide should point to https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.4/html/configuring/provisioning-and-using-your-custom-configuration, as a custom config map is mandatory. This PR is the first step: make the mandatory field visible in https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-876/configuring/#provisioning-your-custom-configuration

@themr0c
Copy link
Member

themr0c commented Jan 27, 2025

@kadel Can we merge this PR already, and adress the rest in subsequent pull requests?

@themr0c
Copy link
Member

themr0c commented Jan 27, 2025

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this, it makes things a little bit better, but I don't think that this solves the https://issues.redhat.com/browse/RHIDP-5373 issue

@themr0c themr0c merged commit fd18de9 into redhat-developer:main Jan 28, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #884

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants