Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Jan 28, 2025

What does this PR do?

chore: release note updates:

  • remove RHIDP-5308 (dupe of RHIDP-5319, affects 1.5);
  • add RHIDP-5734 for GKE support;
  • Judy's copy update for RHIDP-5344;
  • dedupe RHIDP-5342 vs RHIDP-5344;
  • temporarily remove RHIDP-4695 as it's not quite done

You can ignore whitespace changes at https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/887/files?w=1 (?w=1 suffix) so that you're not wondering about all the line ending diffs

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… add rhidp-5734 for GKE support; Judy's copy update for RHIDP-5344; dedupe 5342 vs 5344; temporarily remove RHIDP-4695 as it's not quite done

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt changed the title chore: release note updates: remove 5308... chore: release note updates for GKE support and other misc updates Jan 28, 2025
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 28, 2025

Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

…dupe 5342 vs 5344; temporarily remove RHIDP-4695 as it's not quite done
Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Member

@pabel-rh pabel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a very minor comment.

@themr0c themr0c enabled auto-merge (squash) January 29, 2025 10:21
@themr0c themr0c merged commit 7eff3ff into release-1.4 Jan 29, 2025
3 checks passed
@themr0c themr0c deleted the add-gke-to-rn branch January 29, 2025 13:40
jmagak pushed a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Feb 17, 2025
…edhat-developer#887)

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Fabrice Flore-Thébault <[email protected]>

Added missing parameter in auth set up

Added missing parameter in auth setup

Add missing parameter

Update the missing parameter in auth set up

Added missing parameter in auth set up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants