Skip to content

Conversation

@Gerry-Forde
Copy link
Member

@Gerry-Forde Gerry-Forde commented Feb 9, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Feb 9, 2025

…HDH instance by the Operator (redhat-developer#937)

* fixed merge conflicts

* Incorporated Jessica's comments

* Made a few changes

* Final changes

* Incorporated Lindsey's comments

* Final update

* Incorporated comments

* Incorporated comment

---------

Co-authored-by: Priyanka Abel <[email protected]>
@Gerry-Forde
Copy link
Member Author

Gerry-Forde commented Mar 10, 2025

@rm3l @Fortune-Ndlovu
Could you please provide a technical review of this PR which documents that the Dynamic Plugin cache PVC is disabled by default?

@Fortune-Ndlovu
Copy link
Member

@Gerry-Forde I have reviewed the PR, overall looks technically accurate. I have added some minor comments.

@hmanwani-rh
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: I cannot cherry-pick the present PR on top of its base branch (release-1.5).

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gerry-Forde
Copy link
Member Author

Gerry-Forde commented Mar 13, 2025

@linfraze Can you please provide an approval for this PR, I've applied most of your suggestions from the peer-review and as you suggested, I've also created a separate Jira to modularize this content. Technical reviews are completed and approved.

@rm3l
Copy link
Member

rm3l commented Mar 13, 2025

I cannot cherry-pick the present PR on top of its base branch (release-1.5).

@hmanwani-rh @Gerry-Forde This PR seems to be opened against release-1.5. So I guess it should be cherry-picked to main now..

@Gerry-Forde
Copy link
Member Author

/cherry-pick main

@openshift-cherrypick-robot
Copy link
Contributor

@Gerry-Forde: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one teeny change

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hmanwani-rh hmanwani-rh merged commit 025bcbf into redhat-developer:release-1.5 Mar 18, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: base branch (release-1.5) needs to differ from target branch (release-1.5)

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@Gerry-Forde: #919 failed to apply on top of branch "main":

Applying: RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default
Applying: RHDH-5561: TechDocs content restructure (#917)
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-techdocs.adoc
Falling back to patching base and 3-way merge...
Auto-merging assemblies/assembly-configuring-techdocs.adoc
No changes -- Patch already applied.
Applying: Changed alpha2 to alpha3 (#928)
Using index info to reconstruct a base tree...
M	modules/configuring-deployment/proc-configuring-deployment-by-using-the-operator.adoc
M	modules/dynamic-plugins/con-dynamic-plugins-cache.adoc
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: RHIDP-5592:Wrong definition of Service Monitor for an RHDH instance by the Operator (#937)
.git/rebase-apply/patch:48: trailing whitespace.
==== 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/observe/proc-admin-enabling-metrics-ocp-operator.adoc
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: chore: bad link in code snippet points to non-existent branch (#940)
Using index info to reconstruct a base tree...
M	modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
CONFLICT (content): Merge conflict in modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0005 chore: bad link in code snippet points to non-existent branch (#940)

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@hmanwani-rh: #919 failed to apply on top of branch "main":

Applying: RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default
Applying: RHDH-5561: TechDocs content restructure (#917)
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-techdocs.adoc
Falling back to patching base and 3-way merge...
Auto-merging assemblies/assembly-configuring-techdocs.adoc
No changes -- Patch already applied.
Applying: Changed alpha2 to alpha3 (#928)
Using index info to reconstruct a base tree...
M	modules/configuring-deployment/proc-configuring-deployment-by-using-the-operator.adoc
M	modules/dynamic-plugins/con-dynamic-plugins-cache.adoc
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: RHIDP-5592:Wrong definition of Service Monitor for an RHDH instance by the Operator (#937)
.git/rebase-apply/patch:48: trailing whitespace.
==== 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/observe/proc-admin-enabling-metrics-ocp-operator.adoc
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: chore: bad link in code snippet points to non-existent branch (#940)
Using index info to reconstruct a base tree...
M	modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
CONFLICT (content): Merge conflict in modules/installation/proc-install-rhdh-airgapped-environment-ocp-operator.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0005 chore: bad link in code snippet points to non-existent branch (#940)

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Gerry-Forde added a commit to Gerry-Forde/red-hat-developers-documentation-rhdh-v2 that referenced this pull request Mar 18, 2025
…y default (redhat-developer#919)

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHDH-5561: TechDocs content restructure (redhat-developer#917)

Co-authored-by: linfraze <[email protected]>

* Changed alpha2 to alpha3 (redhat-developer#928)

Co-authored-by: Priyanka Abel <[email protected]>

* [release-1.5] RHIDP-5592:Wrong definition of Service Monitor for an RHDH instance by the Operator (redhat-developer#937)

* fixed merge conflicts

* Incorporated Jessica's comments

* Made a few changes

* Final changes

* Incorporated Lindsey's comments

* Final update

* Incorporated comments

* Incorporated comment

---------

Co-authored-by: Priyanka Abel <[email protected]>

* chore: bad link in code snippet points to non-existent branch (redhat-developer#940)

Co-authored-by: Nick Boldt <[email protected]>

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Armel Soro <[email protected]>

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update con-dynamic-plugins-cache.adoc

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

---------

Co-authored-by: OpenShift Cherrypick Robot <[email protected]>
Co-authored-by: linfraze <[email protected]>
Co-authored-by: Priyanka Abel <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
Co-authored-by: Armel Soro <[email protected]>
hmanwani-rh added a commit that referenced this pull request Mar 24, 2025
…#995)

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default (#919)

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHDH-5561: TechDocs content restructure (#917)

Co-authored-by: linfraze <[email protected]>

* Changed alpha2 to alpha3 (#928)

Co-authored-by: Priyanka Abel <[email protected]>

* [release-1.5] RHIDP-5592:Wrong definition of Service Monitor for an RHDH instance by the Operator (#937)

* fixed merge conflicts

* Incorporated Jessica's comments

* Made a few changes

* Final changes

* Incorporated Lindsey's comments

* Final update

* Incorporated comments

* Incorporated comment

---------

Co-authored-by: Priyanka Abel <[email protected]>

* chore: bad link in code snippet points to non-existent branch (#940)

Co-authored-by: Nick Boldt <[email protected]>

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Armel Soro <[email protected]>

* RHIDP-5570 - Document that the Dynamic Plugin cache PVC is disabled by default

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update con-dynamic-plugins-cache.adoc

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

---------

Co-authored-by: OpenShift Cherrypick Robot <[email protected]>
Co-authored-by: linfraze <[email protected]>
Co-authored-by: Priyanka Abel <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
Co-authored-by: Armel Soro <[email protected]>

* RHIDP-5605  - Plugin installation documentation improvement for adding 'forceDownload' field (#988)

* RHIDP-5605  - Plugin installation documentation improvement for adding 'forceDownload' field

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* Update modules/dynamic-plugins/con-dynamic-plugins-cache.adoc

Co-authored-by: Lindsey Frazier <[email protected]>

* RHIDP-5605  - Plugin installation documentation improvement for adding 'forceDownload' field

---------

Co-authored-by: Lindsey Frazier <[email protected]>

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* [release-1.5] RHIDP-1595: How to use HA in RHDH (#999)

* Added content and rectified an error in another proc

* Added title

* Changing using to configuring

* Changing OCP to an attribute

* Fixing build error

* Alessandro's comment

* Fixed typos

* Fabrice's comments

* Incorporated Lindsey's comments

* Fabrice's comments

* Fixing yaml issue

* Minor change - Lindsey's comment

---------

Co-authored-by: Priyanka Abel <[email protected]>

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* RHIDP-3393 - Document how users can access Plugin Marketplace in RHDH

* Update modules/dynamic-plugins/proc-catalog-viewing.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update modules/dynamic-plugins/con-catalog-searching-and-filtering.adoc

Co-authored-by: Heena Manwani <[email protected]>

* Update con-catalog-searching-and-filtering.adoc

* Update assembly-extensions-plugins.adoc - Add TP banner

* Update assemblies/dynamic-plugins/assembly-extensions-plugins.adoc

Co-authored-by: Heena Manwani <[email protected]>

---------

Co-authored-by: OpenShift Cherrypick Robot <[email protected]>
Co-authored-by: linfraze <[email protected]>
Co-authored-by: Priyanka Abel <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
Co-authored-by: Armel Soro <[email protected]>
Co-authored-by: Heena Manwani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants