RHIDP-5514: Floating action button by pabel-rh · Pull Request #925 · redhat-developer/red-hat-developers-documentation-rhdh

pabel-rh · 2025-02-11T07:39:44Z

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
main, 1.5
Add the relevant labels to the Pull Request.
Issue:
RHIDP-5514
Preview link:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-925/customizing/#configuring-a-floating-action-button

rhdh-bot · 2025-02-11T07:42:13Z

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-925/ @ 03/11/25 07:12:05

debsmita1 · 2025-02-12T13:17:13Z

/lgtm

christoph-jerolimov

Hi @pabel-rh, hi @debsmita1,

thanks for this. It's great to have it. But one small and one medium request:

I personally would not use the term onClick. It's really technical and then customers can not use this.

And I don't think we should document the "static way" to use the global floating action button. From my understanding, that's not an option for RHDH customers.

For engineers and the upstream community, we should provide a good plugin README and maybe a (tech) docs folder in the plugin.

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc

assemblies/assembly-install-and-configuring-a-floating-action-button.adoc

...ing-a-floating-action-button/proc-configuring-floating-action-button-as-a-static-plugin.adoc

...iguring-a-floating-action-button/proc-install-floating-action-button-as-a-static-plugin.adoc

linfraze · 2025-02-18T20:21:01Z

@pabel-rh can you please paste the deep preview link(s) in the PR description so they are easy to find and review? :)

linfraze

A few considerations

assemblies/assembly-install-and-configuring-a-floating-action-button.adoc

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc

...guring-a-floating-action-button/proc-install-floating-action-button-as-a-dynamic-plugin.adoc

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc

assemblies/assembly-install-and-configuring-a-floating-action-button.adoc

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc

assemblies/assembly-configuring-a-floating-action-button.adoc

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc

debsmita1 · 2025-03-11T13:27:00Z

LGTM!
Thanks @pabel-rh !

debsmita1

/lgtm

jmagak · 2025-03-13T07:33:28Z

/cherry-pick release-1.5

openshift-cherrypick-robot · 2025-03-13T07:34:16Z

@jmagak: new pull request created: #981

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pabel-rh temporarily deployed to external February 11, 2025 07:39 — with GitHub Actions Inactive

pabel-rh temporarily deployed to external February 11, 2025 07:43 — with GitHub Actions Inactive

pabel-rh temporarily deployed to external February 11, 2025 08:23 — with GitHub Actions Inactive

pabel-rh added Peer review needed 📖 do-no-merge/review-in-progress 👀 Technical review needed 🔩 Test all the procedures labels Feb 11, 2025

pabel-rh force-pushed the rhidp-5514 branch from 1207407 to 53406fa Compare February 11, 2025 11:47

pabel-rh temporarily deployed to external February 11, 2025 11:47 — with GitHub Actions Inactive

pabel-rh requested a review from debsmita1 February 11, 2025 11:48

pabel-rh temporarily deployed to external February 11, 2025 12:17 — with GitHub Actions Inactive

pabel-rh temporarily deployed to external February 12, 2025 11:41 — with GitHub Actions Inactive

openshift-ci bot assigned debsmita1 Feb 12, 2025

openshift-ci bot added the lgtm label Feb 12, 2025

pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Feb 13, 2025

christoph-jerolimov suggested changes Feb 17, 2025

View reviewed changes

themr0c removed the lgtm label Feb 17, 2025

pabel-rh force-pushed the rhidp-5514 branch from 5eca842 to a331ac8 Compare February 17, 2025 09:17

pabel-rh temporarily deployed to external February 17, 2025 09:17 — with GitHub Actions Inactive

pabel-rh temporarily deployed to external February 18, 2025 08:36 — with GitHub Actions Inactive

pabel-rh added Technical review needed 🔩 Test all the procedures and removed Technical review done ⛅ Any procedure has been succesfully tested labels Feb 18, 2025

linfraze reviewed Feb 18, 2025

View reviewed changes

linfraze added Peer review done 📘 and removed Peer review needed 📖 labels Feb 18, 2025

pabel-rh temporarily deployed to external February 19, 2025 09:28 — with GitHub Actions Inactive

debsmita1 suggested changes Feb 20, 2025

View reviewed changes

pabel-rh added 9 commits March 10, 2025 16:07

Incorporated Lindsey's comments

ceb89d5

Refined content

daf8cbc

Changed topic name

2c03a40

Updated priority description

1daab79

Incorporated Heena's comments

b6aadaf

Minor changes

eb59886

Minor change

a8ec9cb

Removed the part that talked about enabling

018f8b7

Removed unwanted step

6c80e6d

pabel-rh force-pushed the rhidp-5514 branch from 784e6df to 6c80e6d Compare March 10, 2025 10:38

pabel-rh temporarily deployed to external March 10, 2025 10:38 — with GitHub Actions Inactive

debsmita1 reviewed Mar 10, 2025

View reviewed changes

assemblies/assembly-configuring-a-floating-action-button.adoc Outdated Show resolved Hide resolved

Minor change

cc8e378

pabel-rh temporarily deployed to external March 10, 2025 14:44 — with GitHub Actions Inactive

debsmita1 reviewed Mar 10, 2025

View reviewed changes

...ng-a-floating-action-button/proc-configuring-floating-action-button-as-a-dynamic-plugin.adoc Show resolved Hide resolved

Added svg icon example

09cb812

pabel-rh temporarily deployed to external March 11, 2025 07:09 — with GitHub Actions Inactive

pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested Ready to merge 💂 and removed do-no-merge/review-in-progress 👀 Technical review needed 🔩 Test all the procedures labels Mar 12, 2025

debsmita1 self-requested a review March 12, 2025 13:23

debsmita1 approved these changes Mar 12, 2025

View reviewed changes

openshift-ci bot added the lgtm label Mar 12, 2025

jmagak approved these changes Mar 13, 2025

View reviewed changes

jmagak merged commit 53184bc into redhat-developer:main Mar 13, 2025
3 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 13, 2025

[release-1.5] RHIDP-5514: Floating action button #981

Merged

Conversation

pabel-rh commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhdh-bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

debsmita1 commented Feb 12, 2025

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linfraze commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linfraze left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

debsmita1 commented Mar 11, 2025

Uh oh!

debsmita1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagak commented Mar 13, 2025

Uh oh!

openshift-cherrypick-robot commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pabel-rh commented Feb 11, 2025 •

edited

Loading

rhdh-bot commented Feb 11, 2025 •

edited

Loading

linfraze commented Feb 18, 2025 •

edited

Loading