RHIDP-5433: Applied modularization changes for the Customizing title #948
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-948/ @ 03/20/25 12:06:19 |
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
A few considerations, but this PR makes so many improvements! Thank you!
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-home-page/proc-defining-the-layout-of-the-product-home-page.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-home-page/proc-defining-the-layout-of-the-product-home-page.adoc
Outdated
Show resolved
Hide resolved
...ick-access-card/proc-using-a-dedicated-service-to-provide-data-to-the-quick-access-card.adoc
Show resolved
Hide resolved
...ick-access-card/proc-using-a-dedicated-service-to-provide-data-to-the-quick-access-card.adoc
Show resolved
Hide resolved
...ick-access-card/proc-using-a-dedicated-service-to-provide-data-to-the-quick-access-card.adoc
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
A few considerations, but looking great!
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-home-page/proc-defining-the-layout-of-the-product-home-page.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Outdated
Show resolved
Hide resolved
pabel-rh
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
and removed
Ready to merge 💂
Peer review done 📘
labels
christoph-jerolimov
left a comment
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Lgtm. Thanks @pabel-rh
pabel-rh
added
do-no-merge/review-in-progress 👀
and removed
do-not-merge/work-in-progress
labels
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
This is looking really good, but it seems there is a need to modularize a little more granularly or apply guidelines for formatting optional/conditional steps, as it seems that we are currently formatting 2 separate procedures or options as sequential steps of the same procedure.
modules/customizing-the-appearance/proc-customize-rhdh-sidebar-menuitems.adoc
Show resolved
Hide resolved
pabel-rh
added
Ready to merge 💂
Peer review done 📘
and removed
Peer review needed 📖
do-no-merge/review-in-progress 👀
labels
|
/cherry-pick release-1.4 |
|
@hmanwani-rh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.5 |
|
@hmanwani-rh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hmanwani-rh: new pull request created: #1001 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hmanwani-rh: new pull request created: #1002 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
10 participants
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
main, 1.5, 1.4.x
Add the relevant labels to the Pull Request.
Issue:
RHIDP-5433
Preview link:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-948/customizing/#customizing-appearance