RHIDP-5490: Configure global header in RHDH#954
Merged
Gerry-Forde merged 20 commits intoredhat-developer:mainfrom Mar 21, 2025
Conversation
jmagak
changed the title
jmagak
changed the title
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-954/ @ 03/21/25 16:11:38 |
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
1430afc to
ff441bd
Compare
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
ff441bd to
79e110b
Compare
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
f77c390 to
8285ebe
Compare
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
c26478a to
8b1c678
Compare
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
0aa3aef to
a452899
Compare
jmagak
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
jmagak
force-pushed
the
RHIDP-5490-Document-how-to-enable-disable-and-configure-global-header-in-RHDH
branch
from
06cc50f to
809cc65
Compare
added 8 commits
March 19, 2025 13:27
Update the configure global header Update the configure global header Update the configure global header Update the configure global header Update the configure global header
ciiay
suggested changes
Mar 20, 2025
Member
ciiay
left a comment
ciiay
left a comment
There was a problem hiding this comment.
Thank you for the PR, it looks nice, just found a small wording issue.
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
ciiay
reviewed
Mar 20, 2025
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Show resolved
Hide resolved
linfraze
approved these changes
Mar 20, 2025
Member
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
A few minor things that would be good to fix before merging if we have time
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
ciiay
suggested changes
Mar 21, 2025
Member
ciiay
left a comment
ciiay
left a comment
There was a problem hiding this comment.
Hi @jmagak , I have added some comments to address @benwilcock 's concern from testing day. Let me know if you have further questions. Also let's ask Ben for confirmation too once you finish this update. Thank you 🙌
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
linfraze
approved these changes
Mar 21, 2025
Member
linfraze
left a comment
linfraze
left a comment
There was a problem hiding this comment.
Nice doc! A couple optional suggestions, but this looks good to go.
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Show resolved
Hide resolved
modules/configuring-the-global-header/proc-customize-rhdh-global-header.adoc
Outdated
Show resolved
Hide resolved
Member
|
/cherrypick release-1.5 |
Contributor
|
@Gerry-Forde: new pull request created: #1009 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): main, 1.5
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5490
Preview: 6. Configuring the global header in Red Hat Developer Hub