Skip to content

Conversation

@Gerry-Forde
Copy link
Member

@Gerry-Forde Gerry-Forde commented Mar 8, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.5

Issue:
RHIDP-6323

Preview
Dynamic Plugins Reference 1.5

Future update in https://issues.redhat.com/browse/RHIDP-6405

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Mar 8, 2025

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
but with some comments

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2025

New changes are detected. LGTM label has been removed.

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple Qs about specifying # of plugins, but LGTM from a peer review POV

@Gerry-Forde
Copy link
Member Author

@nickboldt Could you please provide an approval for this PR?

Just to note that #968, which you previously approved, is a duplicate of this PR but some of the plugin versions have been updated in this PR, so I guess this one is more up-to-date (I ran the script about two weeks ago).

After re-running the script to generate the dynamic plugins table, the .z versions of two Marketplace plugins had been upgraded.
@Gerry-Forde
Copy link
Member Author

Gerry-Forde commented Mar 24, 2025

Script re-run and only one change was picked up to the Marketplace plugin versions. These have been now updated.

@Gerry-Forde Gerry-Forde added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Mar 24, 2025
@hmanwani-rh hmanwani-rh merged commit efb2c1a into redhat-developer:release-1.5 Mar 24, 2025
3 checks passed
@Gerry-Forde
Copy link
Member Author

/cherrypick main

@openshift-cherrypick-robot
Copy link
Contributor

@Gerry-Forde: new pull request created: #1011

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants