-
Notifications
You must be signed in to change notification settings - Fork 34
fix: add volume for extension catalog entities [RHIDP-11292] #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Type(Describe updated until commit d7c78fd)Enhancement Description
|
| Relevant files | |||||||||
|---|---|---|---|---|---|---|---|---|---|
| Tests |
| ||||||||
| Formatting |
| ||||||||
| Configuration changes |
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||||||||
a11ebb9 to
d7c78fd
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, thanks @rm3l, I also wonder if the docs/dynamic-plugins.md file should be updated to document, for example:
## Extensions Catalog Entities
Starting from version 1.9, the operator extracts catalog entities from the catalog index image
to the `/extensions` directory. This allows the extensions backend providers to automatically
discover plugin metadata for display in the RHDH Extensions UI.
The extraction directory can be configured via the `CATALOG_ENTITIES_EXTRACT_DIR` environment
variable in the `install-dynamic-plugins` init container.d7c78fd to
30e2590
Compare
Co-authored-by: Gennady Azarenkov <[email protected]>
30e2590 to
480229d
Compare
Co-authored-by: Fortune Ndlovu <[email protected]>
480229d to
6bd36a8
Compare
|
redhat-developer/rhdh#3988 merged. /hold cancel |
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should also verify the Name field for the extensions-catalog volume mount?
…r-add-a-new-marketplace-volume-into-the-rhdh-pod-and-set-catalog-entities-extraction-dir-to-it
…11292] Co-authored-by: Fortune Ndlovu <[email protected]>
|
Fortune-Ndlovu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fortune-Ndlovu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |



Description
As discussed in https://redhat-internal.slack.com/archives/C04CUSD4JSG/p1767790419980379, we need to extract the catalog entities from the index image to the
/marketplace/extensions(added in redhat-developer/rhdh-plugins#2006) folder, so that the extensions backend providers can automatically discover them. Otherwise, there are no plugins displayed in the RHDH Extensions UI.redhat-developer/rhdh#3970 added support for specifying the extraction dir via a new
CATALOG_ENTITIES_EXTRACT_DIRenv var, which we now need to set in the Install Methods (and additionally add the right volume mounts - we cannot create that folder right in the main container because the root filesystem is read-only for security purposes).On hold until redhat-developer/rhdh#3988 is merged.Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Before
With the changes here