-
Notifications
You must be signed in to change notification settings - Fork 40
Add entity-feedback workspace #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add entity-feedback workspace #1790
Conversation
|
/publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the Entity Feedback workspace from the Backstage community-plugins repository, enabling like/dislike and star rating functionality for catalog entities in RHDH. The workspace targets Backstage version 1.45.3, which is the current target version used across many workspaces in this repository.
Changes:
- Added entity-feedback workspace configuration files
- Updated CODEOWNERS to assign ownership
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workspaces/entity-feedback/source.json | Defines source repository (backstage/community-plugins) at commit 8f9b3b0 with Backstage version 1.45.3 |
| workspaces/entity-feedback/plugins-list.yaml | Lists the frontend and backend plugins to be packaged from the workspace |
| .github/CODEOWNERS | Adds @durandom as owner for the entity-feedback workspace, correctly positioned alphabetically |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Publish workflow has completed with success.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
|
|
|
/publish |
|
Publish workflow has completed with success.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
|
❌ These plugins failed to load: Error logs from container |
|
/publish |
|
Publish workflow has completed with success.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
Adds Entity Feedback plugin from backstage/community-plugins to RHDH Extensions Catalog. - Frontend: @backstage-community/plugin-entity-feedback (0.12.0) - Backend: @backstage-community/plugin-entity-feedback-backend (0.14.0) - Upstream: backstage/community-plugins @ 8f9b3b0 - Backstage version: 1.45.3 (exact match)
- Package metadata for frontend and backend plugins - Plugin entity for Extensions Catalog - Added to all.yaml for catalog discovery
The backend plugin requires @backstage/plugin-notifications-node which needs to be bundled into the dynamic plugin.
3338322 to
2ae1365
Compare
|
/publish |
|
|
✅ Test workflow passed. All plugins loaded successfully. |
|
Publish workflow has completed with success.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
|
✅ Test workflow passed. All plugins loaded successfully. |
|
Hi David, This PR was created through an AI-assisted workflow pilot, but based on a real request (RHDHPLAN-272 - 1.9 plugin candidates). Good catch on #1195! We discovered a gap in our onboarding workflow — we checked if the plugin workspace already existed, but didn't check for open PRs. That's now logged as a workflow improvement. Our PR is more complete than the auto-generated one:
Happy to mark #1195 as superseded by this one, or we can close ours and port the additions to #1195 — whichever you prefer. |
To avoid noise, this should be logged as a blocker so we don't churn out PRs that will just get closed as dupes.
Which one is more correct? Per slack chat I've added the |
|
this will supersede #1195 |



Summary
Adds Entity Feedback plugin from backstage/community-plugins to RHDH Extensions Catalog.
Plugins
@backstage-community/plugin-entity-feedback@backstage-community/plugin-entity-feedback-backendPlugin Features
Checklist
source.jsoncreated (commit8f9b3b0)plugins-list.yamlcreated (with--embed-package @backstage/plugin-notifications-node)/publishtriggered - images publishedVerification
Tested locally with RHDH Local using PR artifacts:
Initializing Entity Feedback backendLoaded dynamic frontend plugin '@backstage-community/plugin-entity-feedback-dynamic'Published Images
Notes
@backstage/plugin-notifications-nodeembedded (for owner notifications feature)Related