Skip to content

feat(lightspeed): add conversation sorting with persistence, persisting pinned chats and pinned chats toggle per-user #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
its-mitesh-kumar wants to merge 16 commits into from
Closed

feat(lightspeed): add conversation sorting with persistence, persisting pinned chats and pinned chats toggle per-user #1998

its-mitesh-kumar wants to merge 16 commits into from

Conversation

@its-mitesh-kumar
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar commented Jan 5, 2026 •
edited
Loading

Description

Adds conversation sorting and per-user settings persistence using Backstage's StorageApi. Users can now sort conversations by date (newest/oldest) or name (A-Z/Z-A) via a dropdown next to the search input. Pinned chats, the pinned chats toggle state, and sort order now persist across sessions, scoped per-user. Upgraded @patternfly/chatbot to 6.5.0-prerelease.28 for searchActionEnd prop support.

Fixes

UI after Changes

Screen.Recording.2026-01-05.at.10.04.13.PM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@its-mitesh-kumar
adding github signin provider
de90556 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar
adding changeset
88eabdd 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar
removing changeset
69d7e0d 
Signed-off-by: its-mitesh-kumar <[email protected]>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 5, 2026 •
edited
Loading

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed minor v1.1.1

@its-mitesh-kumar its-mitesh-kumar changed the title Feat/light speed feat(lightspeed): add conversation sorting with persistence, persisting pinned chats and pinned chats toggle per-user Jan 5, 2026
@debsmita1 debsmita1 requested a review from aprilma419 January 5, 2026 16:52
@debsmita1
Copy link
Member

debsmita1 commented Jan 5, 2026

@aprilma419 Should we change the sort icon when the order is changed?

@aprilma419
Copy link

aprilma419 commented Jan 6, 2026

@aprilma419 Should we change the sort icon when the order is changed?

@debsmita1 Good catch. Yes, we should change the icon if the order is changed -- show the "sort-amount-down-alt" icon as below:
fa-sort-amount-down-alt

BTW, added the annotation in Figma too: https://www.figma.com/design/urwU8VqRvHfbxMqxeVknrv/RHDH-Lightspeed---AI-Assistant?node-id=2678-8255&t=465CSXMtfcMw9Lw7-1

HusneShabbir
HusneShabbir reviewed Jan 6, 2026
View reviewed changes
Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks correct. The only concern is the warning and how it may affect testing /cc @jrichter1
Screenshot 2026-01-06 at 12 21 36 PM

rhdh-bot and others added 7 commits January 6, 2026 13:23
@rhdh-bot @github-actions @its-mitesh-kumar
Version Packages (redhat-developer#1971)
4f43072 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@lokanandaprabhu @its-mitesh-kumar
feat(orchestrator): add fetch:error:skip and fetch:response:default o…
cd51622 
…ptions for form widgets (redhat-developer#1985)

* feat: add fetch:error:skip and fetch:response:default options for form widgets

* refactor: rename fetch:error:skip to fetch:error:ignoreUnready for clarity
@PreetiW @its-mitesh-kumar
chore: RHINENG-22798 handle cost.[cluster_name] permission (redhat-de…
90b33c1 
…veloper#1996)

* chore: RHINENG-22798 handle cost.[cluster_name] permission

* chore - simplified api call to get clusters

* chore: fixed router tests

* chore :  fixed prettier

* chore: updated api reports
@its-mitesh-kumar @debsmita1
Update workspaces/lightspeed/app-config.yaml
1347816 
Co-authored-by: Debsmita Santra <[email protected]>
@its-mitesh-kumar
feat(lightspeed): sorting chats, persisting chat order, pinned chat, …
5dfc692 
…toggle pinned chat

Signed-off-by: its-mitesh-kumar <[email protected]>
@polasudo @its-mitesh-kumar
fix(orchestrator): resolve TypeScript compilation errors (redhat-deve…
eb137a9 
…loper#1990)

* fix(orchestrator): resolve TypeScript compilation errors

Fixes RHIDP-11204

This PR fixes TypeScript compilation errors in the orchestrator plugins:

1. Fix incorrect import paths:
   - Change '@backstage/types/index' to '@backstage/types' in 7 files

2. Add missing type declarations:
   - Add '@types/js-yaml' to devDependencies in orchestrator-common
   - Add '@types/js-yaml' to devDependencies in scaffolder-backend-module-orchestrator

3. Add missing devDependencies for frontend plugin:
   - Add 'react', 'react-dom', 'react-router-dom' to orchestrator devDependencies
     (required for dynamic plugin export to resolve peer dependencies)

Files modified:
- plugins/orchestrator-common/package.json
- plugins/orchestrator/package.json
- plugins/scaffolder-backend-module-orchestrator/package.json
- plugins/orchestrator-form-react/src/components/AuthRequester.tsx
- plugins/orchestrator-form-widgets/src/uiPropTypes.ts
- plugins/orchestrator-form-widgets/src/utils/evaluateTemplate.test.ts
- plugins/orchestrator-form-widgets/src/utils/useFetch.ts
- plugins/orchestrator-form-widgets/src/utils/useFetchAndEvaluate.ts
- plugins/orchestrator/src/utils/deepSearchObject.ts
- plugins/scaffolder-backend-module-orchestrator/src/actions/getWorkflowParams.ts

* fix(orchestrator-form-widgets): add react-dom and react-router-dom to peerDependencies

- Add react-dom and react-router-dom to peerDependencies in orchestrator-form-widgets
- This fixes the webpack bundling error during scalprum dynamic plugin export
- Ensures these dependencies are treated as externals rather than bundled

* chore: update yarn.lock for orchestrator-form-widgets peerDependencies

- Update yarn.lock to reflect react-dom and react-router-dom peerDependencies changes
- Ensures proper dependency resolution for dynamic plugin export

* Fix TypeScript compilation errors for multiple packages

This change addresses multiple TypeScript compilation errors that were hindering builds, including import path corrections, adding missing type declarations, and resolving peer dependencies.

* fix(changeset): add proper YAML frontmatter to fix-tsc-compilation-errors.md
@its-mitesh-kumar
adding changeset
30a772b 
Signed-off-by: its-mitesh-kumar <[email protected]>
@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Jan 6, 2026

Hi @its-mitesh-kumar, I see a new dependency @monaco-editor/react but no usage (in the diff) for this. Is this dependency used?

@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 6, 2026 •
edited
Loading

@aprilma419 Should we change the sort icon when the order is changed?

@debsmita1 Good catch. Yes, we should change the icon if the order is changed -- show the "sort-amount-down-alt" icon as below:
BTW, added the annotation in Figma too: https://www.figma.com/design/urwU8VqRvHfbxMqxeVknrv/RHDH-Lightspeed---AI-Assistant?node-id=2678-8255&t=465CSXMtfcMw9Lw7-1

@debsmita1 @aprilma419 Now handled.

Screen.Recording.2026-01-06.at.2.33.04.PM.mov

@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 6, 2026 •
edited
Loading

Hi @its-mitesh-kumar, I see a new dependency @monaco-editor/react but no usage (in the diff) for this. Is this dependency used?

@christoph-jerolimov
@monaco-editor/react and monaco-editor are required peer dependencies of @patternfly/[email protected]. We upgraded to this prerelease version to use the new searchActionEnd prop on ChatbotConversationHistoryNav for the sort dropdown feature.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 6, 2026

Closing it as created a PR with clean commits #2003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HusneShabbir HusneShabbir HusneShabbir left review comments

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03 rohitkrai03 is a code owner

@yangcao77 yangcao77 Awaiting requested review from yangcao77 yangcao77 is a code owner

@aprilma419 aprilma419 Awaiting requested review from aprilma419

@ciiay ciiay Awaiting requested review from ciiay

@logonoff logonoff Awaiting requested review from logonoff

@ydayagi ydayagi Awaiting requested review from ydayagi

@mareklibra mareklibra Awaiting requested review from mareklibra

@batzionb batzionb Awaiting requested review from batzionb

@PreetiW PreetiW Awaiting requested review from PreetiW

@asmasarw asmasarw Awaiting requested review from asmasarw

@gciavarrini gciavarrini Awaiting requested review from gciavarrini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@its-mitesh-kumar @debsmita1 @aprilma419 @christoph-jerolimov @HusneShabbir @rhdh-bot @lokanandaprabhu @PreetiW @polasudo @asmasarw