-
Notifications
You must be signed in to change notification settings - Fork 85
feat(lightspeed): add conversation sorting with persistence, persisting pinned chats and pinned chats toggle per-user #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
its-mitesh-kumar
wants to merge
17
commits into
redhat-developer:main
Choose a base branch
from
its-mitesh-kumar:feat/lightspeed-chat-sorting-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e29ffcf
feat(lightspeed): sorting chats, persisting chat order, pinned chat, …
its-mitesh-kumar 23449a0
adding changeset
its-mitesh-kumar 073d002
different icons for different sorting
its-mitesh-kumar 8901948
adding api report
its-mitesh-kumar 3a2e907
updating the version of monaco-editor
its-mitesh-kumar 63223bb
yarn dedupe
its-mitesh-kumar 50b2924
updating test
its-mitesh-kumar 596c41a
resolving sonarqube issues
its-mitesh-kumar b57ca2b
enhance existing e2e
daf0e66
Merge pull request #6 from HusneShabbir/pr/its-mitesh-kumar/2003
its-mitesh-kumar 4f674b7
Merge branch 'main' into feat/lightspeed-chat-sorting-clean
its-mitesh-kumar 1de36ad
unskip file attachemnets
bfb27dd
fix sonar
0dd5d60
test re-str
42c14cd
Merge pull request #7 from HusneShabbir/pr/its-mitesh-kumar/2003
its-mitesh-kumar e2af1cb
adding tests
its-mitesh-kumar 960e422
Merge branch 'main' into feat/lightspeed-chat-sorting-clean
its-mitesh-kumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-lightspeed': minor | ||
| --- | ||
|
|
||
| feat: add conversation sorting with persistence, persisting pinned chats and pinned chats toggle per-user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this PR adding monaco editor as a dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monaco-editor/reactand@monaco-editorare required peer dependencies of@patternfly/[email protected]. We upgraded to this prerelease version to use the newsearchActionEndprop on ChatbotConversationHistoryNav for the sort dropdown feature.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chatbot pre-release verison adds monaco-editor as a peer-dependency, without this in our dependency shows module not found errs