chore(e2e): add Italian (it) and Japanese (ja) locale tests #2097
+170
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusneShabbir
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
its-mitesh-kumar,
karthikjeeyar,
rm3l,
rohitkrai03 and
yangcao77
as code owners
Contributor
|
Given the label for Japanese is in Japanese, you're going to have trouble matching it with the locale string. We might have to use a bit more sophisticated system if we keep adding languages that use different alphabets. |
HusneShabbir
force-pushed
the
add-it-ja-locale-e2e-tests
branch
from
25bd9ab to
b524110
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Italian (
it) and Japanese (ja) locale configurations to Playwright e2e tests across all workspaces that support i18n testing.Changes
Updated
playwright.config.tsin 9 workspaces:Each workspace now runs e2e tests in 4 locales:
en,fr,it,ja.