Skip to content

fix(bulk-import): Simplify routing to single /bulk-import path #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
its-mitesh-kumar wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(bulk-import): Simplify routing to single /bulk-import path #2124

its-mitesh-kumar wants to merge 7 commits into from

Conversation

@its-mitesh-kumar
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar commented Jan 21, 2026 •
edited
Loading

Summary

  • Consolidated multiple duplicate routes that all loaded AddRepositoriesPage into a single /bulk-import path
  • Added catch-all redirect for undefined paths to /bulk-import
  • Removed unused addRepositoriesRouteRef route reference

Breaking Changes

  • Removed addRepositoriesRouteRef from plugin exports

Fixed

UI after changes

Screen.Recording.2026-01-21.at.5.26.49.PM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@its-mitesh-kumar
fix(bulk-import): simplify routing to single /bulk-import path
7851e05 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
adding changeset
fc2158d 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
updating api report
248578b 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar its-mitesh-kumar requested review from a team, debsmita1 and rm3l as code owners January 21, 2026 09:50
@its-mitesh-kumar its-mitesh-kumar requested review from jrichter1 and removed request for a team January 21, 2026 09:50
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 21, 2026 •
edited
Loading

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/bulk-import/packages/app none v0.0.3
@red-hat-developer-hub/backstage-plugin-bulk-import workspaces/bulk-import/plugins/bulk-import major v6.11.1
@red-hat-developer-hub/backstage-plugin-global-floating-action-button workspaces/global-floating-action-button/plugins/global-floating-action-button patch v1.7.2

@its-mitesh-kumar
cleaning the routes
ba0e43c 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
updating e2e for quickstart
6964bfc 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
updating the e2e tests
57509a2 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 21, 2026

/cc @lokanandaprabhu

@its-mitesh-kumar
adding FAB changeset
63c2ddd 
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lokanandaprabhu
lokanandaprabhu approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the functionality is working fine.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2026
@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 22, 2026

/cc @HusneShabbir

@openshift-ci openshift-ci bot requested a review from HusneShabbir January 22, 2026 09:38
christoph-jerolimov
christoph-jerolimov approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @its-mitesh-kumar 👍

Please ensure that you update all the yamls in rhdh repo and overlay repo when updating the plugin.

So I think you should have at least one manual pr in each repo!?

This is much cleaner 👍

@its-mitesh-kumar
Copy link
Member Author

its-mitesh-kumar commented Jan 23, 2026

@christoph-jerolimov This is the PR redhat-developer/rhdh#4029 for cleaning RHDH yaml. Though RHDH PR can go first too it will work properly.
Cc: @debsmita1 @lokanandaprabhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@rm3l rm3l Awaiting requested review from rm3l rm3l is a code owner

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@jrichter1 jrichter1 Awaiting requested review from jrichter1 jrichter1 is a code owner automatically assigned from redhat-developer/rhdh-ui

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@HusneShabbir HusneShabbir Awaiting requested review from HusneShabbir

Assignees

@lokanandaprabhu lokanandaprabhu

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@its-mitesh-kumar @christoph-jerolimov @lokanandaprabhu