feat(localization): adding localization support for the entityTabs title coming from `dynamic-plugins.default.yaml` and `defaultTabs.tsx` #3503

its-mitesh-kumar · 2025-10-03T13:26:44Z

Description

Adding Localization support for EntityTabs being added from

dynamic-plugins.default.yaml :

            entityTabs:
              - path: /workflows
                title: Workflows
                titleKey: app.entityPage.workflows.title
                mountPoint: entity.page.workflows

defaultTabs.tsx

Which issue(s) does this PR fix

Fixes # https://issues.redhat.com/browse/RHIDP-8922

UI after changes

Screen.Recording.2025-10-03.at.6.48.04.PM.mov

How to test changes / Special notes to the reviewer

You can mocked up all the defaults tabs and Workflow tabs using below configuration

frontend:
          
    backstage-community.plugin-jfrog-artifactory:
      entityTabs:
        # 1. Overview tab
        - path: /
          title: Overview
          titleKey: app.entityPage.overview.title
          mountPoint: entity.page.image-registry
        # 2. Topology tab  
        - path: /topology
          title: Topology
          titleKey: app.entityPage.topology.title
          mountPoint: entity.page.image-registry
        # 3. Issues tab
        - path: /issues
          title: Issues
          titleKey: app.entityPage.issues.title
          mountPoint: entity.page.image-registry
        # 4. Pull/Merge Requests tab
        - path: /pr
          title: Pull/Merge Requests
          titleKey: app.entityPage.pullRequests.title
          mountPoint: entity.page.image-registry
        # 5. CI tab
        - path: /ci
          title: CI
          titleKey: app.entityPage.ci.title
          mountPoint: entity.page.image-registry
        # 6. CD tab
        - path: /cd
          title: CD
          titleKey: app.entityPage.cd.title
          mountPoint: entity.page.image-registry
        # 7. Kubernetes tab
        - path: /kubernetes
          title: Kubernetes
          titleKey: app.entityPage.kubernetes.title
          mountPoint: entity.page.image-registry
        # 8. Image Registry tab
        - path: /image-registry
          title: Image Registry
          titleKey: app.entityPage.imageRegistry.title
          mountPoint: entity.page.image-registry
        # 9. Monitoring tab
        - path: /monitoring
          title: Monitoring
          titleKey: app.entityPage.monitoring.title
          mountPoint: entity.page.image-registry
        # 10. Lighthouse tab
        - path: /lighthouse
          title: Lighthouse
          titleKey: app.entityPage.lighthouse.title
          mountPoint: entity.page.image-registry
        # 11. API tab
        - path: /api
          title: Api
          titleKey: app.entityPage.api.title
          mountPoint: entity.page.image-registry
        # 12. Dependencies tab
        - path: /dependencies
          title: Dependencies
          titleKey: app.entityPage.dependencies.title
          mountPoint: entity.page.image-registry
        # 13. Docs tab
        - path: /docs
          title: Docs
          titleKey: app.entityPage.docs.title
          mountPoint: entity.page.image-registry
        # 14. Definition tab
        - path: /definition
          title: Definition
          titleKey: app.entityPage.definition.title
          mountPoint: entity.page.image-registry
        # 15. Diagram tab (System)
        - path: /system
          title: Diagram
          titleKey: app.entityPage.diagram.title
          mountPoint: entity.page.image-registry
      mountPoints:
        - mountPoint: entity.page.image-registry/cards
          importName: JfrogArtifactoryPage
          config:
            layout:
              gridColumn: 1 / -1

Signed-off-by: its-mitesh-kumar <[email protected]>

packages/app/src/components/catalog/EntityPage/EntityPage.tsx

dynamic-plugins.default.yaml

packages/app/src/components/catalog/EntityPage/EntityPage.tsx

packages/app/src/translations/rhdh/ref.ts

packages/app/src/components/catalog/EntityPage/defaultTabs.tsx

Signed-off-by: its-mitesh-kumar <[email protected]>

github-actions · 2025-10-03T14:24:31Z

The image is available at:

Signed-off-by: its-mitesh-kumar <[email protected]>

github-actions · 2025-10-03T15:39:22Z

The image is available at:

christoph-jerolimov · 2025-10-03T16:00:07Z

/retest

christoph-jerolimov

Diff looks good but I didn't tested it yet

github-actions · 2025-10-03T17:12:52Z

The image is available at:

its-mitesh-kumar · 2025-10-03T17:58:57Z

/test e2e-ocp-helm

christoph-jerolimov · 2025-10-05T19:11:35Z

/retest

github-actions · 2025-10-06T05:10:51Z

The image is available at:

its-mitesh-kumar · 2025-10-06T06:12:27Z

/retest

its-mitesh-kumar · 2025-10-06T06:46:45Z

/retest

HusneShabbir · 2025-10-06T08:00:14Z

/retest

its-mitesh-kumar · 2025-10-16T09:01:47Z

/retest

its-mitesh-kumar · 2025-10-16T18:54:14Z

/test e2e-ocp-helm

qodo-merge-pro · 2025-10-16T18:54:18Z

You are above your monthly Qodo Merge usage quota. For more information, please visit here.

invincibleJai · 2025-10-17T05:11:05Z

/retest

Signed-off-by: its-mitesh-kumar <[email protected]>

invincibleJai · 2025-10-17T09:36:10Z

/retest

christoph-jerolimov

From a good review, this lgtm. 👍

github-actions · 2025-10-17T11:54:13Z

The image is available at:

github-actions · 2025-10-17T14:53:04Z

The image is available at:

github-actions · 2025-10-17T21:13:13Z

The image is available at:

its-mitesh-kumar · 2025-10-17T22:00:18Z

/test e2e-ocp-helm

qodo-merge-pro · 2025-10-17T22:00:21Z

You are above your monthly Qodo Merge usage quota. For more information, please visit here.

invincibleJai · 2025-10-18T05:53:10Z

/retest

invincibleJai · 2025-10-18T05:53:50Z

/lgtm

openshift-ci · 2025-10-18T05:53:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, debsmita1, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [christoph-jerolimov,debsmita1,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

invincibleJai · 2025-10-18T08:09:24Z

/retest

openshift-ci · 2025-10-18T09:54:41Z

@its-mitesh-kumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm	`f305716`	link	true	`/test e2e-ocp-helm`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

invincibleJai · 2025-10-18T11:14:27Z

/retest

its-mitesh-kumar added 2 commits October 3, 2025 17:04

feat(localization): add localization support for entityTabs

61017b6

Signed-off-by: its-mitesh-kumar <[email protected]>

translating default tab

48cb330

Signed-off-by: its-mitesh-kumar <[email protected]>

openshift-ci bot requested review from davidfestal and josephca October 3, 2025 13:26

its-mitesh-kumar temporarily deployed to internal October 3, 2025 13:26 — with GitHub Actions Inactive

its-mitesh-kumar changed the title ~~Feat/enitity tabs localization~~ feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx Oct 3, 2025

christoph-jerolimov requested changes Oct 3, 2025

View reviewed changes

removing translation ref from default

a77e95e

Signed-off-by: its-mitesh-kumar <[email protected]>

its-mitesh-kumar temporarily deployed to internal October 3, 2025 14:22 — with GitHub Actions Inactive

Merge branch 'main' into feat/enitity-tabs-localization

cb0774d

its-mitesh-kumar temporarily deployed to internal October 3, 2025 14:24 — with GitHub Actions Inactive

moving prefix of key from app to catalog

fef8811

Signed-off-by: its-mitesh-kumar <[email protected]>

its-mitesh-kumar temporarily deployed to internal October 3, 2025 14:33 — with GitHub Actions Inactive

fixing buld fail

838e3b9

Signed-off-by: its-mitesh-kumar <[email protected]>

its-mitesh-kumar temporarily deployed to internal October 3, 2025 14:39 — with GitHub Actions Inactive

christoph-jerolimov reviewed Oct 3, 2025

View reviewed changes

Merge branch 'main' into feat/enitity-tabs-localization

1c18ada

its-mitesh-kumar temporarily deployed to internal October 3, 2025 16:11 — with GitHub Actions Inactive

Merge branch 'main' into feat/enitity-tabs-localization

b5d7e89

its-mitesh-kumar temporarily deployed to internal October 6, 2025 04:14 — with GitHub Actions Inactive

keeping previous type

199991a

Signed-off-by: its-mitesh-kumar <[email protected]>

its-mitesh-kumar temporarily deployed to internal October 17, 2025 07:26 — with GitHub Actions Inactive

invincibleJai requested a review from christoph-jerolimov October 17, 2025 08:21

Merge branch 'main' into feat/enitity-tabs-localization

ac3cbc5

its-mitesh-kumar temporarily deployed to internal October 17, 2025 10:45 — with GitHub Actions Inactive

Merge branch 'main' into feat/enitity-tabs-localization

37fcd75

its-mitesh-kumar temporarily deployed to internal October 17, 2025 10:55 — with GitHub Actions Inactive

christoph-jerolimov approved these changes Oct 17, 2025

View reviewed changes

Merge branch 'main' into feat/enitity-tabs-localization

d9b07a0

its-mitesh-kumar temporarily deployed to internal October 17, 2025 13:56 — with GitHub Actions Inactive

Merge branch 'main' into feat/enitity-tabs-localization

f305716

its-mitesh-kumar temporarily deployed to internal October 17, 2025 20:11 — with GitHub Actions Inactive

openshift-ci bot assigned invincibleJai Oct 18, 2025

openshift-ci bot added the lgtm label Oct 18, 2025

feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx #3503

Are you sure you want to change the base?

feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx #3503

Conversation

its-mitesh-kumar commented Oct 3, 2025

Description

Which issue(s) does this PR fix

UI after changes

How to test changes / Special notes to the reviewer

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

christoph-jerolimov commented Oct 3, 2025

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

its-mitesh-kumar commented Oct 3, 2025

Uh oh!

christoph-jerolimov commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

its-mitesh-kumar commented Oct 6, 2025

Uh oh!

its-mitesh-kumar commented Oct 6, 2025

Uh oh!

HusneShabbir commented Oct 6, 2025

Uh oh!

its-mitesh-kumar commented Oct 16, 2025

Uh oh!

its-mitesh-kumar commented Oct 16, 2025

Uh oh!

qodo-merge-pro bot commented Oct 16, 2025

Uh oh!

invincibleJai commented Oct 17, 2025

Uh oh!

invincibleJai commented Oct 17, 2025

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

its-mitesh-kumar commented Oct 17, 2025

Uh oh!

qodo-merge-pro bot commented Oct 17, 2025

Uh oh!

invincibleJai commented Oct 18, 2025

Uh oh!

invincibleJai commented Oct 18, 2025

Uh oh!

openshift-ci bot commented Oct 18, 2025

Uh oh!

invincibleJai commented Oct 18, 2025

Uh oh!

openshift-ci bot commented Oct 18, 2025

Uh oh!

invincibleJai commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

feat(localization): adding localization support for the entityTabs title coming from `dynamic-plugins.default.yaml` and `defaultTabs.tsx` #3503

feat(localization): adding localization support for the entityTabs title coming from `dynamic-plugins.default.yaml` and `defaultTabs.tsx` #3503