Skip to content

fix(install-dynamic-plugins): do not extract catalog entities to dynamic-plugins-root by default #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Jan 10, 2026
Merged

fix(install-dynamic-plugins): do not extract catalog entities to dynamic-plugins-root by default #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd68d5
fix(install-dynamic-plugins): do not extract catalog entities to `dyn…
rm3l Jan 10, 2026
3375186
docs: Update docs accordingly
rm3l Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/install-dynamic-plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,8 +1036,8 @@ def main():
catalog_index_image = os.environ.get("CATALOG_INDEX_IMAGE", "")
catalog_index_default_file = None
if catalog_index_image:
# default to <dynamic-plugins-root>/extensions if the env var is not set, to make it easier to run locally.
catalog_entities_parent_dir = os.environ.get("CATALOG_ENTITIES_EXTRACT_DIR", os.path.join(dynamic_plugins_root, "extensions"))
# default to a temporary directory if the env var is not set
catalog_entities_parent_dir = os.environ.get("CATALOG_ENTITIES_EXTRACT_DIR", os.path.join(tempfile.gettempdir(), "extensions"))
catalog_index_default_file = extract_catalog_index(catalog_index_image, dynamic_plugins_root, catalog_entities_parent_dir)

skip_integrity_check = os.environ.get("SKIP_INTEGRITY_CHECK", "").lower() == "true"
Expand Down
4 changes: 2 additions & 2 deletions docs/dynamic-plugins/installing-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ When the `CATALOG_INDEX_IMAGE` is set and the index image contains a `catalog-en
The extraction destination is governed by the `CATALOG_ENTITIES_EXTRACT_DIR` environment variable:

- If `CATALOG_ENTITIES_EXTRACT_DIR` is set, entities are extracted to `<CATALOG_ENTITIES_EXTRACT_DIR>/catalog-entities`
- If not set, it defaults to `<dynamic-plugins-root>/marketplace/catalog-entities`
- If not set, it defaults to `/tmp/extensions/catalog-entities`

**Note:** If the catalog index image does not contain the `catalog-entities/marketplace` directory, a warning will be printed but the extraction of `dynamic-plugins.default.yaml` will still succeed.
**Note:** If the catalog index image does not contain the `catalog-entities/extensions` (or `catalog-entities/marketplace`) directory, a warning will be printed but the extraction of `dynamic-plugins.default.yaml` will still succeed.

## Installing External Dynamic Plugins

Expand Down
Loading